Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/backupccl: TestRestoreRetryProcErr failed #120874

Open
cockroach-teamcity opened this issue Mar 22, 2024 · 3 comments
Open

ccl/backupccl: TestRestoreRetryProcErr failed #120874

cockroach-teamcity opened this issue Mar 22, 2024 · 3 comments
Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months skipped-test T-disaster-recovery
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 22, 2024

ccl/backupccl.TestRestoreRetryProcErr failed on master @ 8dc82e56353b21bd2d01927392cda1aaa3946ad3:

=== RUN   TestRestoreRetryProcErr
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestRestoreRetryProcErr1151826935
    test_log_scope.go:81: use -show-logs to present logs inline
    backup_test.go:1638: -- test log scope end --
test logs left over in: outputs.zip/logTestRestoreRetryProcErr1151826935
--- FAIL: TestRestoreRetryProcErr (15.66s)
=== RUN   TestRestoreRetryProcErr/restore_processor_progress=true
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    backup_test.go:1636: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/backupccl/backup_test.go:1636
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestRestoreRetryProcErr/restore_processor_progress=true
    testutils.go:289: no Invalid Descriptors
    --- FAIL: TestRestoreRetryProcErr/restore_processor_progress=true (7.30s)

Parameters:

  • attempt=1
  • deadlock=true
  • run=1
  • shard=34
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-36921

@cockroach-teamcity cockroach-teamcity added branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Mar 22, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Mar 22, 2024
@msbutler
Copy link
Collaborator

this looks like some sort of race in the test. removing release blocker.

@msbutler msbutler added P-2 Issues/test failures with a fix SLA of 3 months and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 25, 2024
@cockroach-teamcity
Copy link
Member Author

ccl/backupccl.TestRestoreRetryProcErr failed on master @ 644645d578cdeb03d192a52d210e19349627a86d:

=== RUN   TestRestoreRetryProcErr
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestRestoreRetryProcErr1441501220
    test_log_scope.go:81: use -show-logs to present logs inline
    backup_test.go:1638: -- test log scope end --
test logs left over in: outputs.zip/logTestRestoreRetryProcErr1441501220
--- FAIL: TestRestoreRetryProcErr (7.95s)
=== RUN   TestRestoreRetryProcErr/restore_processor_progress=true
    backup_test.go:1636: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/backupccl/backup_test.go:1636
        	            				github.com/cockroachdb/cockroach/pkg/testutils/subtest.go:28
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestRestoreRetryProcErr/restore_processor_progress=true
    testutils.go:289: no Invalid Descriptors
    --- FAIL: TestRestoreRetryProcErr/restore_processor_progress=true (4.02s)

Parameters:

  • attempt=1
  • deadlock=true
  • run=1
  • shard=34
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

msbutler added a commit to msbutler/cockroach that referenced this issue Apr 1, 2024
craig bot pushed a commit that referenced this issue Apr 1, 2024
121469: backupccl: skip restore retry flakey tests r=msbutler a=msbutler

Informs #121336
Informs #120874

Release note: none

Co-authored-by: Michael Butler <butler@cockroachlabs.com>
blathers-crl bot pushed a commit that referenced this issue Apr 1, 2024
Informs #121336
Informs #120874

Release note: none
@msbutler
Copy link
Collaborator

sadly this has been flaking since this test was introduced. so there wasn't a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months skipped-test T-disaster-recovery
Development

No branches or pull requests

2 participants