Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: fix flush_hist_nanos callback in cloud storage and webhook sinks #121248

Open
rharding6373 opened this issue Mar 27, 2024 · 1 comment
Open

changefeedccl: fix flush_hist_nanos callback in cloud storage and webhook sinks #121248

rharding6373 opened this issue Mar 27, 2024 · 1 comment
Assignees
@rharding6373
Labels
A-cdc Change Data Capture backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. P-1 Issues/test failures with a fix SLA of 1 month T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Mar 27, 2024 •
edited by exalate-issue-sync bot

The webhook v1 and cloud storage sinks both execute a callback to update the changefeed.flush_hist_nanos metric immediately, which is inaccurate. For webhook, the callback should be deferred. In the cloud storage sink, we already execute a callback in the async flush code path, so we could eliminate the bad callback and instead add one on the sync flush code path.

Jira issue: CRDB-37153

Epic CRDB-37337
@rharding6373 rharding6373 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture T-cdc backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Mar 27, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Mar 27, 2024

cc @cockroachdb/cdc

@rharding6373 rharding6373 added E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. labels Mar 27, 2024
@rharding6373 rharding6373 mentioned this issue Mar 28, 2024
Closed
@exalate-issue-sync exalate-issue-sync bot added the P-1 Issues/test failures with a fix SLA of 1 month label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rharding6373 rharding6373

Labels
A-cdc Change Data Capture backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-easy Easy issue to tackle, requires little or no CockroachDB experience E-quick-win Likely to be a quick win for someone experienced. P-1 Issues/test failures with a fix SLA of 1 month T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rharding6373