Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: SSH welcome noise #121267

Closed
herkolategan opened this issue Mar 28, 2024 · 1 comment · Fixed by #123458
Closed

roachprod: SSH welcome noise #121267

herkolategan opened this issue Mar 28, 2024 · 1 comment · Fixed by #123458
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team

Comments

@herkolategan
Copy link
Collaborator

herkolategan commented Mar 28, 2024

Upon forming an SSH connection to a roachprod cluster we see the systemctl status check being printed multiple times, likely for each time a node was restarted.

To reproduce:

  1. create a roachprod cluster (one node is enough)
  2. stage cockroach
  3. start and stop cockroach several times on the cluster
# roachprod ssh user-cluster:3
Welcome to Ubuntu 22.04.2 LTS (GNU/Linux 5.19.0-1030-gcp x86_64)

...

cockroach-system is running; see: systemctl status cockroach-system


cockroach-system is running; see: systemctl status cockroach-system


cockroach-system is running; see: systemctl status cockroach-system


cockroach-system is running; see: systemctl status cockroach-system


cockroach-system is running; see: systemctl status cockroach-system


cockroach-system is running; see: systemctl status cockroach-system

Jira issue: CRDB-37165

@herkolategan herkolategan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Mar 28, 2024
Copy link

blathers-crl bot commented Mar 28, 2024

cc @cockroachdb/test-eng

@blathers-crl blathers-crl bot added this to Triage in Test Engineering Mar 28, 2024
@herkolategan herkolategan moved this from Triage to Backlog in Test Engineering Mar 28, 2024
@srosenberg srosenberg added the E-quick-win Likely to be a quick win for someone experienced. label Mar 28, 2024
@herkolategan herkolategan self-assigned this May 2, 2024
herkolategan added a commit to herkolategan/cockroach that referenced this issue May 2, 2024
Previously, multiple entries would be created in "${HOME}/.profile" since the
check for "${HOME}/.profile-cockroach" would always fail. This updates the check
to look for the correct file based on the virtual cluster label.

Fixes: cockroachdb#121267

Epic: None
Release Note: None
craig bot pushed a commit that referenced this issue May 7, 2024
123458: roachprod: fix `start.sh` profile check r=srosenberg,renatolabs a=herkolategan

Previously, multiple entries would be created in "${HOME}/.profile" since the check for "${HOME}/.profile-cockroach" would always fail. This updates the check to look for the correct file based on the virtual cluster label.

Fixes: #121267

Epic: None
Release Note: None

Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
craig bot pushed a commit that referenced this issue May 7, 2024
123458: roachprod: fix `start.sh` profile check r=herkolategan a=herkolategan

Previously, multiple entries would be created in "${HOME}/.profile" since the check for "${HOME}/.profile-cockroach" would always fail. This updates the check to look for the correct file based on the virtual cluster label.

Fixes: #121267

Epic: None
Release Note: None

Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
craig bot pushed a commit that referenced this issue May 7, 2024
123458: roachprod: fix `start.sh` profile check r=herkolategan a=herkolategan

Previously, multiple entries would be created in "${HOME}/.profile" since the check for "${HOME}/.profile-cockroach" would always fail. This updates the check to look for the correct file based on the virtual cluster label.

Fixes: #121267

Epic: None
Release Note: None

123630: streamingest: prevent starting duplicate replication r=dt a=dt

If a tenant is in data set add or drop, another job is already actively writing (or removing) its content, such as another replication job or a restore. In such cases we should not allow another replication job to be started writing to the same tenant.

Release note: none.
Epic: none.

Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
Co-authored-by: David Taylor <tinystatemachine@gmail.com>
craig bot pushed a commit that referenced this issue May 7, 2024
123206: roachprod: load balancer from pgurl command r=srosenberg,renatolabs a=herkolategan

Previously, the load balancer IP or URL can only be retrieved using the expanders. This change adds the ability to also get the URL from the `roachprod` pgurl command by using the `lb` node selector similar to how it is done with expansion.

Epic: None
Release Note: None

123458: roachprod: fix `start.sh` profile check r=srosenberg,renatolabs a=herkolategan

Previously, multiple entries would be created in "${HOME}/.profile" since the check for "${HOME}/.profile-cockroach" would always fail. This updates the check to look for the correct file based on the virtual cluster label.

Fixes: #121267

Epic: None
Release Note: None

Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
@craig craig bot closed this as completed in 43240e4 May 7, 2024
Test Engineering automation moved this from Backlog to Done May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-testeng TestEng Team
Projects
Development

Successfully merging a pull request may close this issue.

2 participants