Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: print lease acquisition type in maybeLogLeaseAcquisition #125082

Closed
nvanbenschoten opened this issue Jun 4, 2024 · 0 comments · Fixed by #125083
Closed

kv: print lease acquisition type in maybeLogLeaseAcquisition #125082

nvanbenschoten opened this issue Jun 4, 2024 · 0 comments · Fixed by #125083
Assignees
@nvanbenschoten
Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-kv KV Team
Projects
KV

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Jun 4, 2024 •
edited by cockroach-jira-scripts
Loading

maybeLogLeaseAcquisition currently logs interesting lease acquisitions. It should include newLease.AcquisitionType in these log messages.

Jira issue: CRDB-39224
@nvanbenschoten nvanbenschoten added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs A-kv-observability T-kv KV Team labels Jun 4, 2024
@nvanbenschoten nvanbenschoten self-assigned this Jun 4, 2024
@nvanbenschoten nvanbenschoten added this to Incoming in KV via automation Jun 4, 2024
@nvanbenschoten nvanbenschoten mentioned this issue Jun 4, 2024
Merged
craig bot pushed a commit that referenced this issue Jun 6, 2024
@nvanbenschoten
Merge #125083
d058298 
125083: kv: print lease acquisition type in maybeLogLeaseAcquisition r=nvanbenschoten a=nvanbenschoten

Fixes #125082.

Release note: None

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig craig bot closed this as completed in 877a1c3 Jun 6, 2024
blathers-crl bot pushed a commit that referenced this issue Jun 6, 2024
@nvanbenschoten
kv: print lease acquisition type in maybeLogLeaseAcquisition
901d435 
Fixes #125082.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Jun 6, 2024
Merged
blathers-crl bot pushed a commit that referenced this issue Jun 6, 2024
@nvanbenschoten
kv: print lease acquisition type in maybeLogLeaseAcquisition
9738e60 
Fixes #125082.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Jun 6, 2024
Merged
Dhruv-Sachdev1313 pushed a commit to Dhruv-Sachdev1313/cockroach that referenced this issue Jun 7, 2024
@nvanbenschoten @Dhruv-Sachdev1313
kv: print lease acquisition type in maybeLogLeaseAcquisition
e705cc4 
Fixes cockroachdb#125082.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvanbenschoten nvanbenschoten

Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-kv KV Team
Projects
KV
Incoming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kv: print lease acquisition type in maybeLogLeaseAcquisition nvanbenschoten/cockroach
1 participant
@nvanbenschoten