Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: expose timeuntilstoredead #13602

Closed
jseldess opened this issue Feb 15, 2017 · 7 comments
Closed

cli: expose timeuntilstoredead #13602

jseldess opened this issue Feb 15, 2017 · 7 comments
Assignees
Milestone

Comments

@jseldess
Copy link
Contributor

Currently, timeuntilstoredead is only an env variable. Based on a chat with @bdarnell, it'd be good to eventually expose this more, ideally as some sort of global configuration for the cluster instead of a flag that needs to be specified on each node. Ben suggested we could easily make it something settable with a new command similar to cockroach zone set.

@petermattis petermattis added this to the 1.0 milestone Feb 23, 2017
@dianasaur323
Copy link
Contributor

Will this fit into the systems table that @dt is working on? Assigning to @dt for now for his thoughts on if this can make it into 1.0. If not, please put into Q3 2017 milestone.

@dt
Copy link
Member

dt commented Apr 12, 2017

I don't know what timeuntilstoredead is, but there's a description of the settings table and what it is intended for here: https://github.com/cockroachdb/cockroach/blob/master/docs/RFCS/settings_table.md

@dt
Copy link
Member

dt commented Apr 12, 2017

but yes, generally env vars are candidates for switching to system.settings

@bdarnell
Copy link
Member

It's here and would definitely be good to move to the settings table.

@BramGruneir
Copy link
Member

I agree, I think it's a perfect candidate.
Also failedReservationsTimeout and declinedReservationsTimeout which are from the store pool. Might be worth renaming them too.

@dt dt assigned BramGruneir and unassigned dt Apr 24, 2017
@petermattis
Copy link
Collaborator

@BramGruneir It should be very easy to get settings added for these. Can you get this done today?

@BramGruneir
Copy link
Member

Yep, already working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants