Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql: typing information for data traveling over the wire on DistSQL streams should be statically configured #13798

Closed
andreimatei opened this issue Feb 24, 2017 · 4 comments
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) help wanted Help is requested / needed by the one who filed the issue to fix it. no-issue-activity X-stale

Comments

@andreimatei
Copy link
Contributor

andreimatei commented Feb 24, 2017

At the moment, the typing information is fed to a StreamDecoder when the first row is passed to the corresponding StreamEncoder. This leads to an awkward communication protocol where the sender/receiver need to keep track of whether they've sent/received this information.
I think it'd be a lot nicer if the typing was inferred and configured as part of the StreamEndpointSpec when the plan is created.

Jira issue: CRDB-6110

@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) help wanted Help is requested / needed by the one who filed the issue to fix it. labels Feb 24, 2017
@RaduBerinde
Copy link
Member

A note on how to add this to the planner: the schema is always available in the corresponding input sync spec; so this could easily be added in PopulateEndoints.

@dianasaur323
Copy link
Contributor

moving to later to match the referenced issue #8792

@dianasaur323 dianasaur323 modified the milestones: Later, Q1 2017 Apr 18, 2017
@knz knz added this to Triage in (DEPRECATED) SQL execution via automation May 14, 2018
@knz knz added the A-sql-execution Relating to SQL execution. label May 14, 2018
@jordanlewis jordanlewis moved this from Triage to Backlog in (DEPRECATED) SQL execution Aug 21, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@jordanlewis jordanlewis moved this from Triage to Lower priority backlog in [DEPRECATED] Old SQLExec board. Don't move stuff here May 9, 2019
@asubiotto asubiotto moved this from Lower priority backlog to [TENT] SQL Exec in [DEPRECATED] Old SQLExec board. Don't move stuff here Apr 2, 2020
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) help wanted Help is requested / needed by the one who filed the issue to fix it. no-issue-activity X-stale
Projects
No open projects
Development

No branches or pull requests

5 participants