Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: string builtins should also be defined for collated strings #20838

Open
justinj opened this issue Dec 18, 2017 · 3 comments
Open

sql: string builtins should also be defined for collated strings #20838

justinj opened this issue Dec 18, 2017 · 3 comments
Labels
A-sql-collated-strings A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@justinj
Copy link
Contributor

justinj commented Dec 18, 2017

Superissue of #20666, there are lots of operations that Postgres supports on collated strings that we don't, for example LIKE (#20666), but also others like LOWER, UPPER, CONCAT, etc.

I'm not sure whether or not it's trivial to define these in terms of their string equivalents - it certainly isn't to do so for the special case of optimizing expressions like LIKE 'abc%', but I think it might be for things like LOWER and UPPER.

cc @knz, @jordanlewis

Jira issue: CRDB-5912

@justinj justinj added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Dec 18, 2017
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL labels Apr 27, 2018
@knz knz added this to Backlog in (DEPRECATED) SQL Front-end, Lang & Semantics via automation Apr 27, 2018
@knz knz moved this from Triage to Backlog in (DEPRECATED) SQL Front-end, Lang & Semantics May 4, 2018
@knz knz removed the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Oct 2, 2018
@asubiotto asubiotto moved this from Backlog to [TENT] SQL Exec in [DEPRECATED] Old SQLExec board. Don't move stuff here Apr 2, 2020
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
@knz
Copy link
Contributor

knz commented Oct 9, 2023

still relevant

@knz knz reopened this Oct 9, 2023
@knz knz added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Oct 9, 2023
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations Oct 9, 2023
@rafiss rafiss added T-sql-queries SQL Queries Team and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Oct 10, 2023
@yuzefovich yuzefovich removed this from Triage in SQL Foundations Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-collated-strings A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
Status: Backlog
Development

No branches or pull requests

4 participants