Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/engine: add version number in rocksdb directory #2718

Closed
bdarnell opened this issue Sep 29, 2015 · 0 comments
Closed

storage/engine: add version number in rocksdb directory #2718

bdarnell opened this issue Sep 29, 2015 · 0 comments
Assignees
@BramGruneir
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
Beta

Comments

@bdarnell
Copy link
Contributor

We should store a version number alongside the rocksdb data and refuse to open newer versions.
@jess-edwards jess-edwards mentioned this issue Sep 29, 2015
Closed
78 tasks
@bdarnell bdarnell mentioned this issue Oct 14, 2015
Closed
@petermattis petermattis changed the title Add version number in rocksdb directory storage/engine: add version number in rocksdb directory Feb 12, 2016
@petermattis petermattis added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 14, 2016
@petermattis petermattis modified the milestone: Beta Feb 14, 2016
@bdarnell bdarnell self-assigned this Feb 18, 2016
@petermattis petermattis assigned BramGruneir and unassigned bdarnell Mar 15, 2016
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 29, 2016
@BramGruneir
storage.engine: add version file to store directory
abc0e87 
This adds a new file VERSION to all store directories. To facilitate this, I've
added a new proto to keep track the format. This has a tiny bit of future
proofing to allow us to have multiple database types with different data
versions as well as a minimum value we support.

When needed, having this file will allow us to automatically perform migrations
during the call to rocksDB.Open().

Fixes cockroachdb#2718.
@BramGruneir BramGruneir mentioned this issue Mar 29, 2016
Merged
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 29, 2016
@BramGruneir
storage.engine: add version file to store directory
892a4ed 
This adds a new file VERSION to all store directories. This has a tiny bit of future proofing to allow us to have multiple databases with different data
versions as well as a minimum value we support.

When needed, having this file will allow us to automatically perform migrations
during the call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 29, 2016
@BramGruneir
storage.engine: add version file to store directory
17f0d48 
This adds a new file VERSION to all store directories. This has a tiny bit of future proofing to allow us to have multiple databases with different data
versions as well as a minimum value we support.

When needed, having this file will allow us to automatically perform migrations
during the call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 30, 2016
@BramGruneir
storage.engine: add version file to store directory
df6761f 
This adds a new file COCKROACHDB_VERSION to all store directories. When needed,
having this file will allow us to automatically perform migrations during the
call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 30, 2016
@BramGruneir
storage.engine: add version file to store directory
0fcc166 
This adds a new file COCKROACHDB_VERSION to all store directories. When needed,
having this file will allow us to automatically perform migrations during the
call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 30, 2016
@BramGruneir
storage.engine: add version file to store directory
b9b3eb9 
This adds a new file COCKROACHDB_VERSION to all store directories. When needed,
having this file will allow us to automatically perform migrations during the
call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 30, 2016
@BramGruneir
storage.engine: add version file to store directory
3f36484 
This adds a new file COCKROACHDB_VERSION to all store directories. When needed,
having this file will allow us to automatically perform migrations during the
call to rocksDB.Open().

Fixes cockroachdb#2718.
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 31, 2016
@BramGruneir
storage.engine: add version file to store directory
fc99884 
This adds a new file COCKROACHDB_VERSION to all store directories. When needed,
having this file will allow us to automatically perform migrations during the
call to rocksDB.Open().

Fixes cockroachdb#2718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BramGruneir BramGruneir

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
3 participants
@bdarnell @BramGruneir @petermattis