Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: RPC versions #2719

Closed
spencerkimball opened this issue Sep 29, 2015 · 4 comments
Closed

rpc: RPC versions #2719

spencerkimball opened this issue Sep 29, 2015 · 4 comments
Assignees
@BramGruneir
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
Q2

Comments

@spencerkimball
Copy link
Member

Communicate and verify version numbers between hosts for the RPC subsystem framing protocol.
@jess-edwards jess-edwards mentioned this issue Sep 29, 2015
Closed
78 tasks
@petermattis petermattis added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 14, 2016
@petermattis petermattis modified the milestone: Beta Feb 14, 2016
@spencerkimball
Copy link
Member Author

@bdarnell is this something we need for beta?

@bdarnell
Copy link
Contributor

Yes. It doesn't need to be fancy; we just need to send "version 1" in our request headers and reject any request that doesn't say "version 1". We don't expect to change this version often (most changes will be backwards-compatible changes to our existing protobufs) but if we do make a fundamental change we should have a way to make sure that old servers don't misinterpret messages from new ones.

(same for the on-disk version of this issue, which isn't assigned to me and I'm having a hard time finding it)

@petermattis petermattis assigned BramGruneir and unassigned bdarnell Mar 15, 2016
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 27, 2016
@BramGruneir
gossip: add a version number to gossip RPCs
aba9331 
This ensures that all gossip RPCs will now be required to contain a version
number to prevent different versions of cockroach gossiping to each other.

Part of cockroachdb#2719
@BramGruneir BramGruneir mentioned this issue Mar 27, 2016
Closed
BramGruneir added a commit to BramGruneir/cockroach that referenced this issue Mar 28, 2016
@BramGruneir
gossip: add a version number to gossip RPCs
930c789 
This ensures that all gossip RPCs will now be required to contain a version
number to prevent different versions of cockroach gossiping to each other.

Part of cockroachdb#2719
@petermattis petermattis changed the title RPC versions rpc: RPC versions Mar 31, 2016
@petermattis petermattis modified the milestones: Beta, Q2 Apr 7, 2016
@spencerkimball
Copy link
Member Author

@BramGruneir is this issue done?

@BramGruneir
Copy link
Member

Sorry, somehow I didn't see this or I would have replied earlier.

No, and the plan right now is to not add the feature until its needed. I was trying to rush to get it in before beta, but after some pushback, it was determined that until we require the versioning, we should leave it as it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BramGruneir BramGruneir

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
Q2
Development

No branches or pull requests
4 participants
@bdarnell @BramGruneir @spencerkimball @petermattis