test: use -logtostderr=NONE
when running benchmarks
#27993
Labels
A-testing
Testing tools and infrastructure
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
no-issue-activity
S-3-productivity
Severe issues that impede the productivity of CockroachDB developers.
Log output is usually just noise when running benchmarks and messes with results (golang/go#25241). The approach has been to use
log.Scope
to redirect log output to a directory. My understanding (cc @benesch) is that we can use-logtostderr=NONE
as an additional flag inmake bench{short}
to disable all log output to stderr for benchmarks that do not calllog.Scope
, with the option of preserving logs with the addition of alog.Scope
to the benchmark. This would silence all benchmarks that do not calllog.Scope
.The main blocker is that some packages do not recognize the
-logtostderr
flag. These packages need theirmain_test.go
files enhanced with a log import similarly topkg/util/caller/main_test.go
The text was updated successfully, but these errors were encountered: