Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use -logtostderr=NONE when running benchmarks #27993

Closed
asubiotto opened this issue Jul 27, 2018 · 2 comments
Closed

test: use -logtostderr=NONE when running benchmarks #27993

asubiotto opened this issue Jul 27, 2018 · 2 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@asubiotto
Copy link
Contributor

Log output is usually just noise when running benchmarks and messes with results (golang/go#25241). The approach has been to use log.Scope to redirect log output to a directory. My understanding (cc @benesch) is that we can use -logtostderr=NONE as an additional flag in make bench{short} to disable all log output to stderr for benchmarks that do not call log.Scope, with the option of preserving logs with the addition of a log.Scope to the benchmark. This would silence all benchmarks that do not call log.Scope.

The main blocker is that some packages do not recognize the -logtostderr flag. These packages need their main_test.go files enhanced with a log import similarly to pkg/util/caller/main_test.go

@asubiotto asubiotto added this to the 2.1 milestone Jul 27, 2018
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers. A-testing Testing tools and infrastructure labels Aug 31, 2018
@petermattis petermattis removed this from the 2.1 milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@knz
Copy link
Contributor

knz commented Jun 7, 2021

we've fixed this

@knz knz closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Development

No branches or pull requests

3 participants