Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restoreccl: RESTORE job description contains option placeholders #28218

Closed
danhhz opened this issue Aug 2, 2018 · 0 comments · Fixed by #28321
Closed

restoreccl: RESTORE job description contains option placeholders #28218

danhhz opened this issue Aug 2, 2018 · 0 comments · Fixed by #28321
Assignees
@maddyblue
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@danhhz
Copy link
Contributor

danhhz commented Aug 2, 2018

If you run a RESTORE with a placeholder in the WITH options, the jobs description doesn't get the placeholder value substituted. We do, however substitute the sink uri.

db.Exec(`RESTORE foo FROM $1 WITH into_db=$2`, `nodelocal:///bar`, `baz`)

will make a job with description:

RESTORE foo FROM 'nodelocal:///bar' WITH into_db=$2

Note that $1 is substituted but $2 is not. It appears that BACKUP has the same bug, but backup only has one option and it doesn't take a value.
@danhhz danhhz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery labels Aug 2, 2018
@maddyblue maddyblue mentioned this issue Aug 7, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 8, 2018
@maddyblue
Merge #28321
ff70e8d 
28321: backupccl: put full option text in job description r=mjibson a=mjibson

Fixes #28218

Release note (bug fix): BACKUP and RESTORE now put placeholder values
into their job descriptions.

Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
@craig craig bot closed this as completed in #28321 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maddyblue maddyblue

Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: put full option text in job description
2 participants
@maddyblue @danhhz