Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace: trace log tags as separate fields #29600

Open
RaduBerinde opened this issue Sep 5, 2018 · 4 comments
Open

trace: trace log tags as separate fields #29600

RaduBerinde opened this issue Sep 5, 2018 · 4 comments
Labels
A-observability-inf A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability
Projects
Cluster UI

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Sep 5, 2018 •
edited by exalate-issue-sync bot

We currently form a message and use a single "event" field. We should put log tags in separate fields.

cockroach/pkg/util/log/trace.go

Lines 129 to 130 in 9c59730

// TODO(radu): pass tags directly to sp.LogKV when LightStep supports
// that.

This impacts session tracing code (in a positive way) - we would use the fields directly instead of parsing the messages.

https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/exec_util.go#L1364

Jira issue: CRDB-4858

Epic CRDB-32402
@RaduBerinde RaduBerinde added this to the 2.2 milestone Sep 5, 2018
@RaduBerinde RaduBerinde self-assigned this Sep 5, 2018
@RaduBerinde RaduBerinde added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-tracing Relating to tracing in CockroachDB. labels Sep 5, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@tbg tbg added this to To be considered in KV 21.1 Stability Period Jan 20, 2021
@tbg tbg moved this from To be considered to Unlikely/Nope in KV 21.1 Stability Period Jan 20, 2021
@tbg tbg added this to Backlog in Cluster UI via automation Mar 9, 2021
@tbg tbg removed this from Unlikely/Nope in KV 21.1 Stability Period Mar 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@knz
Copy link
Contributor

knz commented Jun 5, 2021

still current

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@knz
Copy link
Contributor

knz commented Sep 22, 2023

still current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-observability-inf A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability
Projects
No open projects
Cluster UI
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jlinder @knz @petermattis @RaduBerinde @elinorgarcia