Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: Fix check for existing overlapping replica #2989

Closed
bdarnell opened this issue Nov 3, 2015 · 2 comments
Closed

Store: Fix check for existing overlapping replica #2989

bdarnell opened this issue Nov 3, 2015 · 2 comments

Comments

@bdarnell
Copy link
Contributor

bdarnell commented Nov 3, 2015

Store.addReplicaInternal and CanApplySnapshot use rangesByKey.Has() to detect if a range already exists, but this only looks at a single key so it may be incorrect when there have been multiple splits or merges. This check should be replaced with one that looks at the start and end points of the replica.

See #2944
@veteranlu
Copy link
Contributor

@bdarnell happy to take a look

@bdarnell
Copy link
Contributor Author

Cool, go for it.

veteranlu added a commit to veteranlu/cockroach that referenced this issue Nov 19, 2015
@veteranlu
add hasOverlapReplica to fix cockroachdb#2989
6bcee2a
veteranlu added a commit to veteranlu/cockroach that referenced this issue Nov 20, 2015
@veteranlu
add hasOverlapReplica to fix cockroachdb#2989
e81cf5c
@blathers-crl blathers-crl bot mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdarnell @veteranlu