Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add support for GROUP BY <col num> #3549

Closed
dt opened this issue Dec 29, 2015 · 2 comments
Closed

sql: add support for GROUP BY <col num> #3549

dt opened this issue Dec 29, 2015 · 2 comments
Assignees
@dt

Comments

@dt
Copy link
Member

dt commented Dec 29, 2015

Currently just treats integer expressions as constants.
@dt dt added the SQL label Dec 29, 2015
@dt dt self-assigned this Dec 29, 2015
@petermattis
Copy link
Collaborator

In case you're not aware, sortNode handles similar expressions for ORDER BY. There is either code or implementation ideas to borrow from there.

@dt
Copy link
Member Author

dt commented Dec 29, 2015

Yeah, I started on a little refactoring to share a findRender helper on scanNode.

@dt dt changed the title implement GROUP BY <col num> sql: add support for GROUP BY <col num> Dec 29, 2015
@dt dt mentioned this issue Dec 29, 2015
Closed
dt added a commit to dt/cockroach that referenced this issue Jan 4, 2016
@dt
support 'GROUP BY' column number
5e6fd66 
Fixes cockroachdb#3549.
dt added a commit to dt/cockroach that referenced this issue Jan 4, 2016
@dt
support 'GROUP BY' column number
e32fb6a 
Fixes cockroachdb#3549.
dt added a commit to dt/cockroach that referenced this issue Jan 5, 2016
@dt
support 'GROUP BY' column number
525d758 
Fixes cockroachdb#3549.
dt added a commit to dt/cockroach that referenced this issue Jan 5, 2016
@dt
support 'GROUP BY' column number
91391e8 
Fixes cockroachdb#3549.
dt added a commit to dt/cockroach that referenced this issue Jan 5, 2016
@dt
support 'GROUP BY' column number
1bb99e1 
Fixes cockroachdb#3549.
dt added a commit to dt/cockroach that referenced this issue Jan 5, 2016
@dt
support 'GROUP BY' column number
7d40505 
Fixes cockroachdb#3549.
@dt dt closed this as completed in 86755fa Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt dt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dt @petermattis