Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: clean up makefiles #38

Closed
andybons opened this issue Aug 24, 2014 · 4 comments
Closed

build: clean up makefiles #38

andybons opened this issue Aug 24, 2014 · 4 comments
Assignees
@tbg
Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.

Comments

@andybons
Copy link
Contributor

From #35: "But perhaps we should be vendoring protobuf (and snappy). God, Makefiles suck, why is
librocksdb.a being relinked every time I run make?" – @petermattis
@andybons andybons changed the title build: cleanup makefiles build: clean up makefiles Aug 24, 2014
@andybons andybons mentioned this issue Aug 24, 2014
Closed
@spencerkimball
Copy link
Member

I know. So fucking annoying!

On Saturday, August 23, 2014, Andrew Bonventre notifications@github.com
wrote:

From #35 #35: "But
perhaps we should be vendoring protobuf (and snappy). God, Makefiles suck,
why is
librocksdb.a being relinked every time I run make?" – @petermattis
https://github.com/petermattis

—
Reply to this email directly or view it on GitHub
#38.

@andybons
Copy link
Contributor Author

Just going to put this here for posterity: http://martine.github.io/ninja/

@martine @nico @rsesek

@tbg tbg mentioned this issue Sep 28, 2014
Closed
@tbg tbg self-assigned this Nov 8, 2014
@tbg
Copy link
Member

tbg commented Nov 8, 2014

Pete did a lot of cleaning up so I think the Makefile looks fairly smooth now.
Since I'm vendoring in the remaining dependencies right now I'll take ownership and close this after the PR merges.

@tbg tbg closed this as completed Dec 8, 2014
@andybons
Copy link
Contributor Author

andybons commented Dec 8, 2014

👍

soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
@himanshu144141
Merge pull request cockroachdb#38 from crowdflux/logging_infrastructure
94803e8 
Logging infrastructure
@tbg tbg mentioned this issue Mar 15, 2023
Closed
pav-kv pushed a commit to pav-kv/cockroach that referenced this issue Mar 5, 2024
@ahrtr
Merge pull request cockroachdb#38 from etcd-io/dependabot/github_acti…
918455b 
…ons/actions/setup-go-4

build(deps): bump actions/setup-go from 3 to 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
help wanted Help is requested / needed by the one who filed the issue to fix it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybons @tbg @spencerkimball