Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: statement diagnostics history empty state #46576

Closed
1 task
Annebirzin opened this issue Mar 25, 2020 · 0 comments · Fixed by #46921
Closed
1 task

ui: statement diagnostics history empty state #46576

Annebirzin opened this issue Mar 25, 2020 · 0 comments · Fixed by #46921
Assignees
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.
Projects

Comments

@Annebirzin
Copy link

  • update the empty state on the statement diagnostics history page Figma link

Traces_09

@Annebirzin Annebirzin added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Mar 25, 2020
@Annebirzin Annebirzin added this to Milestone: To Do in Cluster UI Mar 25, 2020
@vladlos vladlos self-assigned this Apr 2, 2020
@vladlos vladlos moved this from Milestone: To Do to Milestone: In Progress in Cluster UI Apr 2, 2020
vladlos added a commit to vladlos/cockroach that referenced this issue Apr 24, 2020
Changed Antd table to own SortedTable table
Added empty state to `Statement Diagnostics History` table

Resolves: cockroachdb#46576

Release note (ui): new design of empty state on Diagnostics report
vladlos added a commit to vladlos/cockroach that referenced this issue Apr 27, 2020
added back lost functionality (link to statements details, tooltip with shortenedStatement, some css)
added loading state
change onClick prop of <Empty/> to handle both callback function or url string

Resolves: cockroachdb#46576

Release note (ui): new design of empty state on Diagnostics report
vladlos added a commit to vladlos/cockroach that referenced this issue Apr 28, 2020
Changed Antd table to own SortedTable table
Added empty state to `Statement Diagnostics History` table

Resolves: cockroachdb#46576

Release note (ui): new design of empty state on Diagnostics report
vladlos added a commit to vladlos/cockroach that referenced this issue May 22, 2020
Changed Antd table to own SortedTable table
Added empty state to `Statement Diagnostics History` table

Resolves: cockroachdb#46576

Release note (ui): new design of empty state on Diagnostics report
vladlos added a commit to vladlos/cockroach that referenced this issue May 27, 2020
added back lost functionality (link to statements details, tooltip with shortenedStatement, some css)
added loading state
added `buttonHref` prop to <Empty/>
minor fixes

Resolves: cockroachdb#46576
@piyush-singh piyush-singh moved this from Milestone: In Progress to Milestone: In Review in Cluster UI Jun 11, 2020
craig bot pushed a commit that referenced this issue Jun 16, 2020
46921: ui: Statement diagnostics history - empty state r=elkmaster a=elkmaster

Use `SortableTable` component instead of antd table, this change gives us oportunity to reuse realisation of empty and loading states of table on Statement diagnostics history page.
Minor updates to <Empty/> component props api, to avoid duplicates of window.open calls
Added storybook for SortableTable empty state.

Resolves: #46576

Release note (ui): new design of empty state of Statement diagnostics history page

![Screenshot 2020-04-24 at 16 11 20](https://user-images.githubusercontent.com/12850886/80216182-57f92580-8646-11ea-832e-8584b3c6c69f.png)


Co-authored-by: Vlad <carrott9@gmail.com>
@craig craig bot closed this as completed in f391b62 Jun 16, 2020
Cluster UI automation moved this from Milestone: In Review to Milestone: Done Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.
Projects
No open projects
Cluster UI
  
Milestone: Done
Development

Successfully merging a pull request may close this issue.

2 participants