Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: populate the engine_type field in sentry report #49368

Closed
knz opened this issue May 21, 2020 · 0 comments
Closed

server: populate the engine_type field in sentry report #49368

knz opened this issue May 21, 2020 · 0 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@knz
Copy link
Contributor

knz commented May 21, 2020

Currently the engine_type field is set to default in sentry reports.

The code is in server.go:

"engine_type": s.cfg.StorageEngine.String(),

It would be better to expand the string into pebble/rocksdb instead, so that the engineer looking at a sentry report doesn't have to first look at the particular version/revision to figure out what the default happens to be.
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. labels May 21, 2020
itsbilal added a commit to itsbilal/cockroach that referenced this issue May 21, 2020
@itsbilal
server: Resolve default engine type in testserver
9f1810c 
Previously we weren't resolving the engine type if it was
set to EngineTypeDefault in the testserver. This would silently
resolve to RocksDB (and in 20.2, pebble) anyway, so it was
only a concern in sentry reports where it would show up as
`default`. Since `cockroach demo` uses the test server and
has sentry reports enabled, that was an oversight.

Fixes cockroachdb#49368.

Release note (bug fix): Report engine type correctly in bug reports
when using `cockroach demo`.
@itsbilal itsbilal mentioned this issue May 21, 2020
Merged
@craig craig bot closed this as completed in 74881ea May 21, 2020
@craig craig bot added this to Done (milestone B) in Storage via automation May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz