Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact: make RedactableString non-constructable #50044

Open
knz opened this issue Jun 10, 2020 · 0 comments
Open

redact: make RedactableString non-constructable #50044

knz opened this issue Jun 10, 2020 · 0 comments
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability

Comments

@knz
Copy link
Contributor

knz commented Jun 10, 2020

Suggested/recommended by @tbg:

A trick we use elsewhere is type RedactableString struct { s string } so you cannot hand-make one.

One issue we'd need to address is that there are a few legitimate casts of string to RedactableString in the log package, specifically in the parsing of log entries from disk.

One option is to make the redact package aware of the "vertical ellipsis protocol" and responsible for serialization to/from disk formats, so that there's no remaining cast to/from strings.

Epic: CRDB-6668

Jira issue: CRDB-4159

@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-logging In and around the logging infrastructure. labels Jun 10, 2020
@knz knz added this to To do in DB Server & Security Jun 15, 2020
@knz knz moved this from To do to Linked issues (see roadmap) in DB Server & Security Jun 15, 2020
@jlinder jlinder added the T-server-and-security DB Server & Security label Jun 16, 2021
@jtsiros jtsiros added T-shared-systems Shared Systems Team and removed T-server-and-security DB Server & Security labels Feb 17, 2022
@jtsiros jtsiros added this to To do in Shared Systems via automation Feb 17, 2022
@jtsiros jtsiros removed this from Linked issues (from the roadmap columns on the right) in DB Server & Security Feb 17, 2022
@knz knz removed this from Backlog in Shared Systems Jun 16, 2022
@knz knz added this to To do in Observability Infrastructure via automation Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability
Projects
No open projects
Development

No branches or pull requests

3 participants