colexec: add optimized support of "contains" LIKE match

[yuzefovich]

We currently have optimized support of LIKE matching for "prefix" match (test%) and "suffix" match (%test). We could also easily add support for "contains" match (%test%) using bytes.Contains function.

This will require the following:

1. updating execgen/like_ops_gen.go to introduce the new "overload" for LIKE operator to be generated (you'll need to run make execgen to regenerate the code)
2. updating colexec/like_ops.go to support new "contains" likeOpType
3. updating GetLikeOperator and GetLikeProjectionOperator methods accordingly
4. adding some tests in logic_test/vectorize.

[clucle]

Hi @yuzefovich I'd like to work this issue if no one is working on it.

[clucle]

Should I add BenchmarkLikeOps in execgen/like_ops_test.go for "contains"?

[yuzefovich]

Hi @clucle, thanks for the interest! I'll assign the issue to you.

In terms of benchmarks, you should adjust BenchmarkLikeOps in colexec/like_ops_test.go to include the "contains" pattern. Also, it'd be nice to add a couple of unit test cases in TestLikeOperators.

[clucle]

cockroach/pkg/sql/colexec/like_ops_test.go

Lines 82 to 92 in 276dd82

	{
	pattern: "%e%",
	tups: tuples{{"abc"}, {"def"}, {"ghi"}},
	expected: tuples{{"def"}},
	},
	{
	pattern: "%e%",
	negate: true,
	tups: tuples{{"abc"}, {"def"}, {"ghi"}},
	expected: tuples{{"abc"}, {"ghi"}},
	},

In my opinion, it seems that TestLikeOperators already contain the test, so I didn't reflect it.

Should I add a test case?

[clucle]

@yuzefovich

I don't know how to add a reviewer( #51598 ) because this is my first contribution to this project.

Help me plz 😄

[yuzefovich]

In my opinion, it seems that TestLikeOperators already contain the test, so I didn't reflect it.

Oh yeah, I didn't see it. No need for extra test case then.

[yuzefovich]

This issue has been addressed by #51636.