-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colexec: add optimized support of "contains" LIKE match #51636
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is a conflict with tpch_vec
again.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @clucle)
pkg/sql/logictest/testdata/logic_test/tpch_vec, line 731 at r2 (raw file):
│ └ *colexec.mergeJoinInnerOp │ ├ *colexec.selContainsBytesBytesConstOp │ │ └ *colfetcher.colBatchScan
This will fail - colBatchScan
has just been exported., so we need to keep colfetcher.ColBatchScan
.
Previously, Like matching has "prefix" match(test%) and "suffix" match(%test). This commit adds "contains" match (%test%) using bytest.Contains function. Release note (sql change): Add support for "contains" match(%test%) using bytes.Contains function
pkg/sql/logictest/testdata/logic_test/tpch_vec, line 731 at r2 (raw file): Previously, yuzefovich wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! bors r=yuzefovich
Reviewed 1 of 1 files at r3.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
bors r=yuzefovich |
We're having a lot of issues with bors for some reason. bors r=yuzefovich |
Do I need to rebase upstream/master and push again? |
No need, our merging bot has been mysteriously crashing. bors r=yuzefovich |
Build failed (retrying...) |
Build failed (retrying...) |
bors r=yuzefovich |
Build succeeded: |
Previously, Like matching has "prefix" match(test%) and "suffix" match(%test).
This commit adds "contains" match (%test%) using bytest.Contains function.
Release note (sql change): Add support for "contains" match(%test%) using bytes.Contains function