sql: remove experimental prefix from functions #52139

chriscasano · 2020-07-30T15:59:44Z

For several functions like: experimental_strftime(), experimental_uuid_v4() and experimental_follower_read_timestamp(), these functions will have to be refactored in applications that are using them when they no longer are experimental. We should think of a different way of introducing experimental functions so they don't have to be refactored in applications.

Update from @rafiss

The product team is coming up with a definition for "alpha" and "beta" features. Once that is established, let's create aliases for all existing experimental functions and settings. (i.e., just make a new name without experimental_ in the name that points to the existing thing.)

Session settings:

experimental_distsql_planning
experimental_enable_temp_tables
experimental_enable_implicit_column_partitioning
experimental_enable_hash_sharded_indexes
experimental_enable_unique_without_index_constraints
experimental_use_new_schema_changer

Cluster settings:

sql.defaults.experimental_distsql_planning
sql.spatial.experimental_box2d_comparison_operators.enabled

Functions:

experimental_uuid_v4
experimental_strftime
experimental_strptime

cc @vy-ton

Jira issue: CRDB-3979

The text was updated successfully, but these errors were encountered:

blathers-crl · 2020-07-30T15:59:46Z

Hello, I am Blathers. I am here to help you get the issue triaged.

It looks like you have not filled out the issue in the format of any of our templates. To best assist you, we advise you to use one of these templates.

I have CC'd a few people who may be able to assist you:

@mattcrdb (member of the technical support engineering team)

If we have not gotten back to your issue within a few business days, you can try the following:

Join our community slack channel and ask on #cockroachdb.
Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

knz · 2020-07-30T16:01:43Z

cc @awoods187

FYI the proposal has been to migrate away from the word "experimental" inside the SQL syntax, and instead emphasize the experimental nature in docs, contextual help and product announcements.

So we could remove these occurrences of "experimental" even if the functionality remains in fact experimental.

rafiss · 2021-03-23T20:03:31Z

cc @vy-ton and @piyush-singh -- this seems related to the alpha/beta product process that i've heard about recently

awoods187 · 2021-05-05T13:39:50Z

+1 on doing this during the next release

74337: kv: pool rangeCacheKey objects r=arulajmani a=nvanbenschoten This commit introduces a `sync.Pool` for `rangeCacheKey` objects. This is used to avoid heap allocations when querying and updating the `RangeCache`. ``` name old time/op new time/op delta KV/Scan/Native/rows=1-10 14.8µs ± 2% 14.9µs ± 4% ~ (p=0.356 n=9+10) KV/Scan/SQL/rows=1-10 92.1µs ± 4% 94.3µs ± 5% ~ (p=0.113 n=9+10) name old alloc/op new alloc/op delta KV/Scan/Native/rows=1-10 6.87kB ± 0% 6.85kB ± 0% -0.35% (p=0.000 n=10+10) KV/Scan/SQL/rows=1-10 20.0kB ± 0% 20.0kB ± 0% -0.25% (p=0.012 n=10+10) name old allocs/op new allocs/op delta KV/Scan/Native/rows=1-10 52.0 ± 0% 51.0 ± 0% -1.92% (p=0.000 n=10+10) KV/Scan/SQL/rows=1-10 244 ± 0% 242 ± 0% -0.78% (p=0.000 n=10+10) ``` ---- This is part of a collection of assorted micro-optimizations: - #74336 - #74337 - #74338 - #74339 - #74340 - #74341 - #74342 - #74343 - #74344 - #74345 - #74346 - #74347 - #74348 Combined, these changes have the following effect on end-to-end SQL query performance: ``` name old time/op new time/op delta KV/Scan/SQL/rows=1-10 94.4µs ±10% 92.3µs ±11% -2.20% (p=0.000 n=93+93) KV/Scan/SQL/rows=10-10 102µs ±10% 99µs ±10% -2.16% (p=0.000 n=94+94) KV/Update/SQL/rows=10-10 378µs ±15% 370µs ±11% -2.04% (p=0.003 n=95+91) KV/Insert/SQL/rows=1-10 133µs ±14% 132µs ±12% ~ (p=0.738 n=95+93) KV/Insert/SQL/rows=10-10 197µs ±14% 196µs ±13% ~ (p=0.902 n=95+94) KV/Update/SQL/rows=1-10 186µs ±14% 185µs ±14% ~ (p=0.351 n=94+93) KV/Delete/SQL/rows=1-10 132µs ±13% 132µs ±14% ~ (p=0.473 n=94+94) KV/Delete/SQL/rows=10-10 254µs ±16% 250µs ±16% ~ (p=0.086 n=100+99) name old alloc/op new alloc/op delta KV/Scan/SQL/rows=1-10 20.1kB ± 0% 19.1kB ± 1% -4.91% (p=0.000 n=96+96) KV/Scan/SQL/rows=10-10 21.7kB ± 0% 20.7kB ± 1% -4.61% (p=0.000 n=96+97) KV/Delete/SQL/rows=10-10 64.0kB ± 3% 63.7kB ± 3% -0.55% (p=0.000 n=100+100) KV/Update/SQL/rows=1-10 45.8kB ± 1% 45.5kB ± 1% -0.55% (p=0.000 n=97+98) KV/Update/SQL/rows=10-10 105kB ± 1% 105kB ± 1% -0.10% (p=0.008 n=97+98) KV/Delete/SQL/rows=1-10 40.8kB ± 0% 40.7kB ± 0% -0.08% (p=0.001 n=95+96) KV/Insert/SQL/rows=1-10 37.4kB ± 1% 37.4kB ± 0% ~ (p=0.698 n=97+96) KV/Insert/SQL/rows=10-10 76.4kB ± 1% 76.4kB ± 0% ~ (p=0.822 n=99+98) name old allocs/op new allocs/op delta KV/Scan/SQL/rows=1-10 245 ± 0% 217 ± 0% -11.43% (p=0.000 n=95+92) KV/Scan/SQL/rows=10-10 280 ± 0% 252 ± 0% -10.11% (p=0.000 n=75+97) KV/Delete/SQL/rows=10-10 478 ± 0% 459 ± 0% -4.04% (p=0.000 n=94+97) KV/Delete/SQL/rows=1-10 297 ± 1% 287 ± 1% -3.34% (p=0.000 n=97+97) KV/Update/SQL/rows=1-10 459 ± 0% 444 ± 0% -3.27% (p=0.000 n=97+97) KV/Insert/SQL/rows=1-10 291 ± 0% 286 ± 0% -1.72% (p=0.000 n=82+86) KV/Update/SQL/rows=10-10 763 ± 1% 750 ± 1% -1.68% (p=0.000 n=96+98) KV/Insert/SQL/rows=10-10 489 ± 0% 484 ± 0% -1.03% (p=0.000 n=98+98) ``` 85730: kvserver: also block LEARNER snaps to paused followers r=erikgrinaker a=tbg We checked whether the snapshot recipient was paused only in the raft log queue path. By pushing the check down into `sendSnapshot`, it is now hit by any snapshot attempt, which includes the replicate queue and store rebalancer. For best results, both of these should avoid moving replicas to paused followers in the first place, which they already do, at least partially, so this change shouldn't have much of an impact in practice. Fixes #85479. Release note: None 85732: kvserver: only pause followers when holding active lease r=erikgrinaker a=tbg If the raft leader is not the leaseholder (which includes the case in which we just transferred the lease away), leave all followers unpaused. Otherwise, the leaseholder won't learn that the entries it submitted were committed which effectively causes range unavailability. Fixes #84884. Release note: None 85756: builtins: add strptime/strftime builtins without experimental prefix r=rafiss a=rafiss refs #52139 These are just an alias for the existing implementation. Release note (sql change): The strptime and strftime builtin functions were added as aliases for experimental_strptime and experimental_strftime. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>

blathers-crl bot added O-community Originated from the community X-blathers-oncall labels Jul 30, 2020

knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 30, 2020

rohany added this to Triage in SQL Features (Deprecated - use SQL Experience board) via automation Jul 30, 2020

solongordon moved this from Triage to Backlog in SQL Features (Deprecated - use SQL Experience board) Aug 11, 2020

rafiss added this to Triage in SQL Sessions - Deprecated via automation Feb 8, 2021

rafiss mentioned this issue Mar 10, 2021

release-21.1: sql: move ALTER TYPE ... DROP VALUE behind a feature flag #61723

Merged

rafiss removed the O-community Originated from the community label Mar 10, 2021

rafiss moved this from Triage to Shorter term backlog in SQL Sessions - Deprecated Mar 30, 2021

rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021

otan removed the X-blathers-oncall label Oct 14, 2021

rafiss mentioned this issue Aug 8, 2022

builtins: add strptime/strftime builtins without experimental prefix #85756

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sql: remove experimental prefix from functions #52139

sql: remove experimental prefix from functions #52139

chriscasano commented Jul 30, 2020 •

edited by cockroach-jira-scripts

blathers-crl bot commented Jul 30, 2020

knz commented Jul 30, 2020

rafiss commented Mar 23, 2021

awoods187 commented May 5, 2021

sql: remove experimental prefix from functions #52139

sql: remove experimental prefix from functions #52139

Comments

chriscasano commented Jul 30, 2020 • edited by cockroach-jira-scripts

blathers-crl bot commented Jul 30, 2020

knz commented Jul 30, 2020

rafiss commented Mar 23, 2021

awoods187 commented May 5, 2021

chriscasano commented Jul 30, 2020 •

edited by cockroach-jira-scripts