Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: implement ALTER MATERIALIZED VIEW and DROP MATERIALIZED VIEW #52733

Closed
rohany opened this issue Aug 12, 2020 · 0 comments · Fixed by #52840
Closed

sql: implement ALTER MATERIALIZED VIEW and DROP MATERIALIZED VIEW #52733

rohany opened this issue Aug 12, 2020 · 0 comments · Fixed by #52840
Assignees
@rohany
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
SQL Features (Deprecated - use SQL Ex...

Comments

@rohany
Copy link
Contributor

rohany commented Aug 12, 2020

These commands are just translated to the standard ALTER VIEW/DROP VIEW commands. This can be done once #52530 lands.
@rohany rohany added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 12, 2020
@rohany rohany self-assigned this Aug 12, 2020
rohany added a commit to rohany/cockroach that referenced this issue Aug 14, 2020
@rohany
sql: implement ALTER MATERIALIZED VIEW and DROP MATERIALIZED VIEW
7f5b627 
Fixes cockroachdb#52733.

Release note (sql change): Implement the `ALTER MATERIALIZED VIEW` and
`DROP MATERIALIZED VIEW` commands.
@rohany rohany mentioned this issue Aug 14, 2020
Merged
craig bot pushed a commit that referenced this issue Aug 18, 2020
@rohany
Merge #52840
22421bb 
52840: sql: implement `ALTER MATERIALIZED VIEW` and `DROP MATERIALIZED VIEW` r=rohany a=rohany

Fixes #52733.

Release note (sql change): Implement the `ALTER MATERIALIZED VIEW` and
`DROP MATERIALIZED VIEW` commands.

Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
@craig craig bot closed this as completed in fb2d6e3 Aug 18, 2020
SQL Features (Deprecated - use SQL Experience board) automation moved this from 20.2.e to Done Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohany rohany

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
No open projects
SQL Features (Deprecated - use SQL Ex...
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: implement ALTER MATERIALIZED VIEW and DROP MATERIALIZED VIEW rohany/cockroach
1 participant
@rohany