kv,sql: test propagation of trace spans on error #55594
Labels
A-kv-observability
A-sql-observability
Related to observability of the SQL layer
A-tracing
Relating to tracing in CockroachDB.
C-investigation
Further steps needed to qualify. C-label will change.
T-kv
KV Team
Projects
The KV layer does (or at least should) propagate trace recordings on errors. We the
*BatchResponse
as a carrier, which also carries any*Error
.cockroach/pkg/server/node.go
Lines 980 to 982 in 81c9c91
The SQL layer uses RemoteProducerMetadata (or ProducerMetadata? I'm not quite sure):
cockroach/pkg/sql/execinfrapb/data.go
Lines 286 to 290 in 8e5e54f
It hopefully also does propagate errors.
While introducing always-on tracing, we want to spend some time making sure that errors in fact do correctly propagate through traces at all times via the introduction of suitable tests where they do not yet exist.
Jira issue: CRDB-3655
The text was updated successfully, but these errors were encountered: