Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: ensure all errors are recorded in always-on trace #55595

Open
tbg opened this issue Oct 15, 2020 · 0 comments
Open

kv: ensure all errors are recorded in always-on trace #55595

tbg opened this issue Oct 15, 2020 · 0 comments
Labels
A-kv-observability A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
Observability Infrastructure KV

Comments

@tbg
Copy link
Member

tbg commented Oct 15, 2020 •
edited by cockroach-jira-scripts

Errors should always be part of the recorded always-on trace. In particular, *roachpb.Error is trace metadata.

We will need to decide who is in charge of adding errors to the trace at the DistSender->KVServer boundary (either way will work).
There are various other internal errors that can be "retried away"; these also need to be added to the trace. A classic example of that is a transaction refresh, which is terminated in the TxnCoordSender.

Jira issue: CRDB-3654
@tbg tbg added A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Oct 15, 2020
@tbg tbg added this to MH (Irfan Raphael Sam Tobias) in KV 21.1 Stability Period Oct 15, 2020
@tbg tbg added the A-tracing Relating to tracing in CockroachDB. label Jan 20, 2021
@tbg tbg moved this from MH (Irfan Raphael Tobias) to NH in KV 21.1 Stability Period Feb 10, 2021
@tbg tbg moved this from NH to To be considered in KV 21.1 Stability Period Mar 4, 2021
@tbg tbg moved this from To be considered to Unlikely/Nope in KV 21.1 Stability Period Mar 4, 2021
@tbg tbg added this to Incoming in KV via automation Mar 9, 2021
@jlinder jlinder added the T-kv KV Team label Jun 16, 2021
@mwang1026 mwang1026 removed this from Incoming in KV Aug 20, 2021
@mwang1026 mwang1026 added this to To do in Observability Infrastructure via automation Aug 20, 2021
@mwang1026 mwang1026 added T-observability-inf and removed T-kv KV Team labels Aug 20, 2021
@exalate-issue-sync exalate-issue-sync bot added T-kv KV Team and removed T-observability-inf labels Apr 11, 2023
@blathers-crl blathers-crl bot added this to Incoming in KV Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-observability A-tracing Relating to tracing in CockroachDB. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
KV
Incoming
Observability Infrastructure
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlinder @tbg @mwang1026