Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: distributed float aggregations don't satisfy the precision requirements #56446

Open
yuzefovich opened this issue Nov 9, 2020 · 1 comment · May be fixed by #107674
Open

sql: distributed float aggregations don't satisfy the precision requirements #56446

yuzefovich opened this issue Nov 9, 2020 · 1 comment · May be fixed by #107674
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-investigation Further steps needed to qualify. C-label will change. T-sql-queries SQL Queries Team
Projects
BACKLOG, NO NEW ISSUES: SQL Execution

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Nov 9, 2020 •
edited by cockroach-jira-scripts

#56348 has several examples in which the computations of aggregate functions in the distributed environment produce the floating-point result that doesn't match the expected one in the 15 significant digits (which is what Postgres supports). Interestingly, this occurs on the statistics aggregates the code for which was ported over from PG. Further investigation is needed into why this occurs, and at the moment we updated the logic test checker to look only at 14 significant digits.

Jira issue: CRDB-2940
@yuzefovich yuzefovich added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-investigation Further steps needed to qualify. C-label will change. labels Nov 9, 2020
@yuzefovich yuzefovich added this to Triage in BACKLOG, NO NEW ISSUES: SQL Execution via automation Nov 9, 2020
@asubiotto asubiotto moved this from Triage to [GENERAL BACKLOG] Enhancements/Features/Investigations in BACKLOG, NO NEW ISSUES: SQL Execution Nov 10, 2020
@jlinder jlinder added the T-sql-queries SQL Queries Team label Jun 16, 2021
michae2 added a commit to michae2/cockroach that referenced this issue Jul 26, 2023
@michae2
testutils/floatcmp: check 15 significant digits
abf49c7 
A few years ago we decreased the precision of our float comparison from
15 significant digits to 14 to silence some test flakes. Let's try
increasing it to 15 again.

Also fix a bug in the comparison due to a `-=` instead of `=`. (Not sure
how *significant* this was.)

Fixes: cockroachdb#56446

Release note: None
@michae2 michae2 linked a pull request Jul 26, 2023 that will close this issue
Draft
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-investigation Further steps needed to qualify. C-label will change. T-sql-queries SQL Queries Team
Projects
BACKLOG, NO NEW ISSUES: SQL Execution
[GENERAL BACKLOG] Enhancements/Featur...
SQL Queries
Status: Cold Storage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testutils/floatcmp: check 15 significant digits michae2/cockroach
2 participants
@jlinder @yuzefovich