Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: don't use filepath.Join for network paths #59143

Open
dt opened this issue Jan 19, 2021 · 1 comment
Open

changefeedccl: don't use filepath.Join for network paths #59143

dt opened this issue Jan 19, 2021 · 1 comment
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-cdc
Projects
[DEPRECATED] CDC

Comments

@dt
Copy link
Member

dt commented Jan 19, 2021 •
edited by cockroach-jira-scripts 

pkg/ccl/changefeedccl/encoder.go:489:	url.Path = filepath.Join(url.EscapedPath(), `subjects`, subject, `versions`)
pkg/ccl/changefeedccl/sink_cloudstorage.go:439:	return s.es.WriteFile(ctx, filepath.Join(part, filename), bytes.NewReader(payload))
pkg/ccl/changefeedccl/sink_cloudstorage.go:533:	return s.es.WriteFile(ctx, filepath.Join(s.dataFilePartition, filename), bytes.NewReader(file.buf.Bytes()))

Jira issue: CRDB-3331
@dt dt added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-cdc Change Data Capture labels Jan 19, 2021
@dt dt added this to Triage in Disaster Recovery Backlog via automation Jan 19, 2021
@dt dt added this to Triage in [DEPRECATED] CDC via automation Jan 19, 2021
@shermanCRL shermanCRL moved this from Triage to Bug in Disaster Recovery Backlog Jan 19, 2021
@dt dt removed this from Bug in Disaster Recovery Backlog Mar 9, 2021
@amruss amruss moved this from Triage to Bugs in [DEPRECATED] CDC Mar 29, 2021
@stevendanna stevendanna removed their assignment Oct 14, 2022
@miretskiy miretskiy added the E-quick-win Likely to be a quick win for someone experienced. label Jan 9, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 28, 2023

cc @cockroachdb/cdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-cdc
Projects
[DEPRECATED] CDC
  
Bugs
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dt @stevendanna @HonoreDB @miretskiy