Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for partial, partitioned, and multi-column inverted indices #63380

Closed
kevin-v-ngo opened this issue Apr 9, 2021 · 2 comments
Closed
Assignees
Labels
A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Apr 9, 2021

Please add usage tracking for partial inverted indices, partitioned inverted indices, and multi-column inverted indices introduced in 21.1 (#59331), (#43643), (#50952).

This will help the team understand feature adoption and improve feature discoverability, usability and documentation.

Please add the following events:

sql.schema.partial_inverted_index
sql.schema.partitioned_inverted_index
sql.schema.multi_column_inverted_index

@kevin-v-ngo kevin-v-ngo created this issue from a note in SQL Queries (Triage) Apr 9, 2021
@blathers-crl
Copy link

blathers-crl bot commented Apr 9, 2021

Hi @kevin-v-ngo, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 9, 2021
@mgartner mgartner self-assigned this Apr 9, 2021
@mgartner mgartner moved this from Triage to 21.2 Milestone A in SQL Queries Apr 9, 2021
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 10, 2021
This commit adds telemetry counters `sql.schema.partial_inverted_index`
and `sql.schema.multi_column_inverted_index`. It also adds telemetry
tests for geography and geometry inverted indexes, which was already
supported.

Informs cockroachdb#63380

Release note: None
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 10, 2021
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 12, 2021
This commit adds telemetry counters `sql.schema.partial_inverted_index`
and `sql.schema.multi_column_inverted_index`. It also adds telemetry
tests for geography and geometry inverted indexes, which was already
supported.

Informs cockroachdb#63380

Release note: None
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 12, 2021
craig bot pushed a commit that referenced this issue Apr 12, 2021
63048: opt: index accelerate JSON filters in the forms j->'a' @> '1' and j->'a' <@ '1' r=angelazxu a=angelazxu

We previously did not have inverted index support for expressions with a
JSON fetch val operator on the left side of @> (contains) or <@ (contained by)
expressions.

This commit adds support to use the inverted index for query filters with JSON
fetch val and containment operators. These include any contains or contained by
expressions with fetch val or chained fetch val operators on the left side, and
a constant value on the right side, including booleans, strings, numbers,
nulls, arrays, and objects.

Fixes #61430

Release note (performance improvement): Expressions with the -> (fetch val)
operator on the left side of either <@ (contained by) or @> (contains) now
support index-acceleration.

63417: sql/ccl: add partial inverted index, multi-column inverted index, and partitioned inverted index telemetry r=mgartner a=mgartner

#### sql: rename "partial_index" telemetry test file to "index"

A single telemetry test file is appropriate for testing all
index-related telemetries.

Release note: None

#### sql: add telemetry for partial and multi-column inverted indexes

This commit adds telemetry counters `sql.schema.partial_inverted_index`
and `sql.schema.multi_column_inverted_index`. It also adds telemetry
tests for geography and geometry inverted indexes, which was already
supported.

Informs #63380

Release note: None

#### sql/ccl: add telemetry for partitioned inverted indexes

Informs #63380

Release note: None


Co-authored-by: Angela Xu <angelax@cockroachlabs.com>
Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 12, 2021
This commit adds telemetry counters `sql.schema.partial_inverted_index`
and `sql.schema.multi_column_inverted_index`. It also adds telemetry
tests for geography and geometry inverted indexes, which was already
supported.

Informs cockroachdb#63380

Release note: None
mgartner added a commit to mgartner/cockroach that referenced this issue Apr 12, 2021
@mgartner
Copy link
Collaborator

mgartner commented May 7, 2021

Resolved by #63417.

@mgartner mgartner closed this as completed May 7, 2021
SQL Queries automation moved this from 21.2 Milestone A to Done May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
Archived in project
Development

No branches or pull requests

2 participants