sql/catalog: remove SchemaKind from SchemaDescriptor #65931
Labels
A-schema-catalog
Related to the schema descriptors collection and the catalog API in general.
A-schema-descriptors
Relating to SQL table/db descriptor handling.
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
Is your feature request related to a problem? Please describe.
Before #65142, we had a concept
ResolvedSchema
which either had a descriptor or had just a modicum of information. This allowed us to cope with the weirdness of public, virtual, and temporary schemas (more or less). In the above referenced PR, we unified this concept around different implementations of the descriptor interface. However, the behavior of these different kinds of descriptors is not perfectly consistent and they do not provide all of the features of a normal schema descriptor. Namely:The reason for this is that the objects are singletons today. It seems scary to allocate new objects every time. It feels like a big disruption to #65142 to add it to that already non-trivial and blocking PR.
Describe the solution you'd like
We should store objects for these things from a node-level cache provided to the collection.
Epic: CRDB-2454
Jira issue: CRDB-7804
The text was updated successfully, but these errors were encountered: