Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: structured log messages record useless file:line #67517

Open
andreimatei opened this issue Jul 12, 2021 · 0 comments
Open

log: structured log messages record useless file:line #67517

andreimatei opened this issue Jul 12, 2021 · 0 comments
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability
Projects
Observability Infrastructure

Comments

@andreimatei
Copy link
Contributor

andreimatei commented Jul 12, 2021 •
edited by cockroach-jira-scripts

Observe the following log message

I210712 23:38:00.117491 471 2@util/log/event_log.go:32 ⋮ [n1] 210 ={"Timestamp":1626133080117488854,"EventType":"runtime_stats","...

Note the util/log/event_log.go:32. This is inside the logging code. What I'd like instead is what log messages generally contain: the caller one frame up from the entry point into the logging lib.

Jira issue: CRDB-8584
@andreimatei andreimatei added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-logging In and around the logging infrastructure. labels Jul 12, 2021
@andreimatei andreimatei added this to To do in DB Server & Security via automation Jul 12, 2021
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Jul 12, 2021
@knz knz moved this from To do to Tech debt & Grouping attempts in DB Server & Security Jul 29, 2021
@thtruo thtruo added T-observability-inf and removed T-server-and-security DB Server & Security labels Feb 18, 2022
@jtsiros jtsiros added this to To do in Observability Infrastructure via automation Feb 22, 2022
@jtsiros jtsiros removed this from Tech debt & Grouping attempts in DB Server & Security Feb 22, 2022
@knz knz removed their assignment Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability
Projects
No open projects
Observability Infrastructure
To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreimatei @knz @thtruo