Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: remove opt field from Statement Statistics #68077

Closed
Azhng opened this issue Jul 26, 2021 · 0 comments · Fixed by #69597
Closed

sql: remove opt field from Statement Statistics #68077

Azhng opened this issue Jul 26, 2021 · 0 comments · Fixed by #69597
Assignees
@Azhng
Labels
A-sql-observability Related to observability of the SQL layer C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@Azhng
Copy link
Contributor

Azhng commented Jul 26, 2021

opt is always true and has been for a couple of releases now. It's not providing much value to us other than taking up much space.

Note: we should remove it both from the protobuf messages as well as system table.

cc: @yuzefovich
@Azhng Azhng added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Jul 26, 2021
@Azhng Azhng added this to Triage in Cluster Observability via automation Jul 26, 2021
@Azhng Azhng added the A-sql-observability Related to observability of the SQL layer label Jul 26, 2021
@Azhng Azhng mentioned this issue Jul 26, 2021
Merged
@maryliag maryliag moved this from Triage to Quick Win in Cluster Observability Aug 9, 2021
@Azhng Azhng self-assigned this Aug 30, 2021
@Azhng Azhng mentioned this issue Aug 30, 2021
Merged
Azhng added a commit to Azhng/cockroach that referenced this issue Aug 30, 2021
@Azhng
roachpb,sql.ui: remove Opt field from StatementStatisticsKey
96c5c29 
Resolves cockroachdb#68077

Release note: None

Release justification:
craig bot pushed a commit that referenced this issue Sep 17, 2021
@Azhng
Merge #69597 #70364
f7c562b 
69597: roachpb,sql.ui: remove Opt field from StatementStatisticsKey r=matthewtodd a=Azhng

Resolves #68077

Release note: None

70364: docs: update readme for cluster-ui r=xinhaoz a=Azhng

Previsouly, README in cluster-ui points to an incorrect directory
to run yarn command.
This commit update the directory mentioned in the README.

Release note: None

Co-authored-by: Azhng <archer.xn@gmail.com>
@craig craig bot closed this as completed in 08b663b Sep 17, 2021
Cluster Observability automation moved this from Quick Win to Done Sep 17, 2021
lindseyjin pushed a commit to lindseyjin/cockroach that referenced this issue Sep 17, 2021
@Azhng @lindseyjin
Merge cockroachdb#69597 cockroachdb#70364
e6ec612 
69597: roachpb,sql.ui: remove Opt field from StatementStatisticsKey r=matthewtodd a=Azhng

Resolves cockroachdb#68077

Release note: None

70364: docs: update readme for cluster-ui r=xinhaoz a=Azhng

Previsouly, README in cluster-ui points to an incorrect directory
to run yarn command.
This commit update the directory mentioned in the README.

Release note: None

Co-authored-by: Azhng <archer.xn@gmail.com>
Azhng added a commit to Azhng/cockroach that referenced this issue Nov 19, 2021
@Azhng
roachpb,sql.ui: remove Opt field from StatementStatisticsKey
f5015d9 
This field is safe to delete because we have been filling this
field with hard coded values since few releases ago.

Resolves cockroachdb#68077

Release note: None

Release justification:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azhng Azhng

Labels
A-sql-observability Related to observability of the SQL layer C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachpb,sql.ui: remove Opt field from StatementStatisticsKey Azhng/cockroach
1 participant
@Azhng