Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: data race in gRPC in v1.39 #68154

Closed
knz opened this issue Jul 28, 2021 · 2 comments
Closed

rpc: data race in gRPC in v1.39 #68154

knz opened this issue Jul 28, 2021 · 2 comments
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. regression Regression from a release.

Comments

@knz
Copy link
Contributor

knz commented Jul 28, 2021

We are seeing many unrelated tests fail with the following data race:

WARNING: DATA RACE
Read at 0x00c0035a4ba0 by goroutine 827:
  google.golang.org/grpc/internal/transport.(*Stream).RecvCompress()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/internal/transport/transport.go:338 +0xf0a

Previous write at 0x00c0035a4ba0 by goroutine 777:
  google.golang.org/grpc/internal/transport.(*http2Client).operateHeaders()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/internal/transport/http2_client.go:1295 +0x2309
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. regression Regression from a release. labels Jul 28, 2021
This was referenced Jul 28, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Merged
@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

Filed upstream: grpc/grpc-go#4626

craig bot pushed a commit that referenced this issue Jul 28, 2021
@knz
Merge #68158
dbbf8fb 
68158: Revert "go.mod: bump cloud.google.com/go/storage to v1.16.0" r=tbg,erikgrinaker a=knz

Reverts #67806

Informs #68154
Informs #65926 

Fixes #68150
Fixes #68152
Fixes  #68148
Fixes #68145
Fixes #68144
Fixes #68143

This reverts commit e52ddc8.

This is because that commit contains an upgrade to gRPC 1.39 which
contains a race condition.

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@tbg tbg closed this as completed Oct 6, 2021
@tbg
Copy link
Member

tbg commented Oct 6, 2021

We're using v1.40 now and the data race has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. regression Regression from a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knz @tbg