Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix makeRangeFilter code to actually be used and normalize non-canonical range span constraints #80627

Open
cucaroach opened this issue Apr 27, 2022 · 1 comment
Open

sql: fix makeRangeFilter code to actually be used and normalize non-canonical range span constraints #80627

cucaroach opened this issue Apr 27, 2022 · 1 comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries

Comments

@cucaroach
Copy link
Contributor

cucaroach commented Apr 27, 2022 •
edited by cockroach-jira-scripts

See #79886 for background. We need to let findJoinFilterRange find non-canonical range spans and let makeRangeFilter massage them into canonical expressions. See #80525 for a possible real world example. Another example could be LIKE expressions that can be spanitized, ie foo LIKE "bar%" -> foo >= "bar" and foo < "bas". Care must be taken to correctly handle NULLs per usual.

Jira issue: CRDB-15573
@cucaroach cucaroach added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 27, 2022
@cucaroach cucaroach self-assigned this Apr 27, 2022
@cucaroach cucaroach added this to Triage in SQL Queries via automation Apr 27, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Apr 27, 2022
@cucaroach cucaroach mentioned this issue Apr 27, 2022
Merged
@rharding6373 rharding6373 moved this from Triage to 22.2 Low Likelihood (10%) in SQL Queries May 3, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@rytaft rytaft moved this from 22.2 Low Likelihood (10%) to 22.2 Release in SQL Queries May 25, 2022
@mgartner mgartner moved this from 22.2 Release to Backlog in SQL Queries Jul 7, 2022
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2024

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
@yuzefovich yuzefovich reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
SQL Queries
Backlog (DO NOT ADD NEW ISSUES)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlinder @yuzefovich @cucaroach