Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: deprecate datestyle_enabled / intervalstyle_enabled #81529

Closed
otan opened this issue May 19, 2022 · 1 comment · Fixed by #82388
Closed

sql: deprecate datestyle_enabled / intervalstyle_enabled #81529

otan opened this issue May 19, 2022 · 1 comment · Fixed by #82388
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated

Comments

@otan
Copy link
Contributor

otan commented May 19, 2022 •
edited by cockroach-jira-scripts

As of v22.1, the reasons for datestyle_enabled and intervalstyle_enabled no longer hold.

We should always assume this is true in the codebase, and removes all checks of these variables (they probably need to hang around for backwards compat).

Jira issue: CRDB-15100
@otan otan added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label May 19, 2022
@otan otan added this to Triage in SQL Sessions - Deprecated via automation May 19, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 19, 2022
@otan otan mentioned this issue May 19, 2022
Merged
@rafiss
Copy link
Collaborator

rafiss commented May 19, 2022

I added the makeBackwardsCompatBoolVar helper function, which should be used for this

@rafiss rafiss moved this from Triage to 22.2 Now in SQL Sessions - Deprecated May 19, 2022
@jlinder jlinder added sync-me and removed sync-me labels May 20, 2022
@rafiss rafiss mentioned this issue Jun 3, 2022
Merged
@craig craig bot closed this as completed in 02cc393 Jun 7, 2022
SQL Sessions - Deprecated automation moved this from 22.2 Now to Done Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: remove date/intervalstyle_enabled from code rafiss/cockroach
3 participants
@jlinder @rafiss @otan