Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: remove date/intervalstyle_enabled from code #82388

Merged
merged 1 commit into from Jun 7, 2022
Merged

sql: remove date/intervalstyle_enabled from code #82388

merged 1 commit into from Jun 7, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jun 3, 2022

fixes #81529

No release note is needed, since v22.1 already included a release note
about how these are both hardcoded to true and cannot be changed.

The session variables and cluster settings remain in the code, but are
marked as retired.

Release note: None

@rafiss rafiss requested a review from otan June 3, 2022 02:27
@rafiss rafiss requested a review from a team as a code owner June 3, 2022 02:27
@rafiss rafiss requested a review from a team June 3, 2022 02:27
@rafiss rafiss requested review from a team as code owners June 3, 2022 02:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor

otan commented Jun 3, 2022 


[02:37:44][run] pkg/sql/sem/cast/cast.go:184:32: undefined: SessionOptions
[02:37:44][run] pkg/sql/sem/cast/cast.go:194:39: undefined: SessionOptions
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:132:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:431:4: unknown field 'intervalStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:444:4: unknown field 'intervalStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:486:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:517:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:536:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:756:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast_map.go:971:4: unknown field 'dateStyleAffected' in struct literal of type Cast
[02:37:44][run] pkg/sql/sem/cast/cast.go:184:32: too many errors

:blob_eye_grin:

@mgartner mgartner self-requested a review June 3, 2022 13:49
@rafiss rafiss force-pushed the remove-style-enabled branch 2 times, most recently from fc2083c to 275cb43 Compare June 3, 2022 18:46
@rafiss rafiss requested a review from a team June 3, 2022 18:46
@rafiss rafiss requested a review from a team as a code owner June 4, 2022 16:10
mgartner
mgartner approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

otan
otan approved these changes Jun 6, 2022
View reviewed changes
pkg/sql/logictest/testdata/logic_test/as_of
@@ -18,7 +18,7 @@ SELECT * FROM t AS OF SYSTEM TIME INTERVAL '-1us'

# Verify that we can use computed expressions.
query I
SELECT * FROM t AS OF SYSTEM TIME -( ('1000' || 'us')::INTERVAL )
SELECT * FROM t AS OF SYSTEM TIME -( parse_interval('1000' || 'us') )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this have to change?

Copy link
Contributor

@otan otan Jun 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, do as of statements have to be immutable? TIL

@rafiss rafiss force-pushed the remove-style-enabled branch 3 times, most recently from dd159e9 to f0726ee Compare June 7, 2022 06:45
@rafiss
sql: remove date/intervalstyle_enabled from code
1fa2c77 
No release note is needed, since v22.1 already included a release note
about how these are both hardcoded to true and cannot be changed.

The session variables and cluster settings remain in the code, but are
marked as retired.

Release note: None
@rafiss
Copy link
Collaborator Author

rafiss commented Jun 7, 2022

tftr!

bors r=otan,mgartner

@craig craig bot merged commit 02cc393 into cockroachdb:master Jun 7, 2022
@craig
Copy link
Contributor

craig bot commented Jun 7, 2022

Build succeeded:

@rafiss rafiss deleted the remove-style-enabled branch June 7, 2022 16:55
@rafiss rafiss mentioned this pull request Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

@mgartner mgartner mgartner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: deprecate datestyle_enabled / intervalstyle_enabled
4 participants
@rafiss @cockroach-teamcity @otan @mgartner