Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: observability related to number of queued connection establishment #82900

Closed
ajwerner opened this issue Jun 14, 2022 · 0 comments · Fixed by #104235
Closed

sql: observability related to number of queued connection establishment #82900

ajwerner opened this issue Jun 14, 2022 · 0 comments · Fixed by #104235
Assignees
@rafiss
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Jun 14, 2022 •
edited by exalate-issue-sync bot

Is your feature request related to a problem? Please describe.

In #66028, we added a semaphore around hashing passwords. This can lead to high connection establishment latency when there is a burst of new connections. We don't have metrics around this limit.

Describe the solution you'd like

It'd be good to have metrics around inbound connection attempts as well as queue size. We could also track latency connection establishment. We should track failed attempts.

Additional context
We also don't have any knobs to increase the concurrency. The setting is controlled with an environment variable.

Jira issue: CRDB-16719

Epic CRDB-27601
@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jun 14, 2022
@rafiss rafiss added this to Triage in Cluster Observability via automation Jun 14, 2022
@rafiss rafiss added this to Triage in SQL Sessions - Deprecated via automation Jun 14, 2022
@blathers-crl blathers-crl bot added T-sql-observability T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jun 14, 2022
@rafiss rafiss added the O-postmortem Originated from a Postmortem action item. label Jun 14, 2022
@kevin-v-ngo kevin-v-ngo moved this from Triage to Backlog in Cluster Observability Jul 11, 2022
@rafiss rafiss added the E-starter Might be suitable for a starter project for new employees or team members. label Aug 10, 2022
@rafiss rafiss moved this from Triage to Smaller fixes/improvements in SQL Sessions - Deprecated Aug 10, 2022
@rafiss rafiss removed the O-postmortem Originated from a Postmortem action item. label Feb 28, 2023
@rafiss rafiss mentioned this issue Jun 1, 2023
Merged
@craig craig bot closed this as completed in b15f6f5 Jun 6, 2023
Cluster Observability automation moved this from Backlog to Done Jun 6, 2023
@blathers-crl blathers-crl bot mentioned this issue Jun 6, 2023
Merged
@rafiss rafiss mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Smaller fixes/improvements
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pgwire: add gauge for connections throttled by semaphore rafiss/cockroach
2 participants
@rafiss @ajwerner