Acceptance testing 22.2 - No insights filter for statement executions #87741
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
kevin-v-ngo
added
the
C-bug
kevin-v-ngo
changed the title
kevin-v-ngo
changed the title
kevin-v-ngo
changed the title
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Dec 20, 2022
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Dec 28, 2022
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 4, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 4, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 5, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 5, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 13, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 13, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 17, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
gtr
added a commit
to gtr/cockroach
that referenced
this issue
Jan 19, 2023
Fixes cockroachdb#87741, cockroachdb#87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages.
craig bot
pushed a commit
that referenced
this issue
Jan 19, 2023
94002: ui: add missing filters for workload insights and active execution pages r=gtr a=gtr Fixes #87741, #87783. Previously, the workload insights page was missing a filter for insights type for both the statement and transaction tabs. Furthermore, the active execution pages for statement and transactions was also missing a status filter. This commit adds the ability to filter by insights type for the workload insights page and the ability to filter by execution status for the active execution pages. DB Console video demos: - [Demo](https://www.loom.com/share/39c7b882b8b84ebfb39203d219f05075) for workload insights page. - [Demo](https://www.loom.com/share/806c1238233741e2b17882e3665ffabf) for active execution page. - [Demo](https://www.loom.com/share/e601c39c20cb45b28aae5ac468216ba6) for selecting more than one option. CC Console video demos - [Demo](https://www.loom.com/share/975b0952a43d4ab6908cbb5a0533f335) for filtering by execution status on statements tab - [Demo](https://www.loom.com/share/f60690b61c8d4665b87b0f31f639596c) for filtering by execution status on transactions tab - [Demo](https://www.loom.com/share/13cd1865edcb4b8d87ba7b89217e697d) for filtering by workload insight type Release note (ui change): added an insights type filter for the workload insights page, added a execution status filter for the active execution pages. Updated the tooltip for execution status to include the definition for the "Waiting" status. 94797: sql: implement strict UDFs with CASE r=mgartner a=mgartner This commit removes the field `CalledOnNullInput` of `tree.RoutineExpr`. Strict UDFs are now wrapped in a `CASE` expression so that they are not invoked when any of the arguments are NULL. This fixes a bug that caused strict functions be evaluated when presented with `NULL` arguments after being inlined. This also allows for the removal of special logic in evaluation of `tree.RoutineExpr`. A positive side effect of this change is that strict UDFs will be folded to NULL at optimization-time if they are presented with constant NULL arguments. This is made possible by existing normalization rules. Fixes #95240 There is no release note because the bug is not present in any releases. Release note: None 95382: upgrades_test: speed up TestRoleMembersIDMigration1500Users test r=rafiss a=andyyang890 This patch speeds up the TestRoleMembersIDMigration1500Users test by moving the creation of test users into transactions. On my Mac, this change reduced the running time from ~55s to ~15s (a 4x speedup). Fixes #95268 Release note: None Co-authored-by: gtr <gerardo@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Andy Yang <yang@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should add an insights filter to BOTH Workload and Schema insights.
There is no Insights filter:
Should be:
Figma: https://www.figma.com/proto/xpnRkP9cLXERVceRC4cec4/22.2_SQL-obsrv_query-performance?node-id=1086%3A89265&scaling=min-zoom&page-id=1086%3A89095&starting-point-node-id=1086%3A89103
Jira issue: CRDB-19509
Epic CRDB-20388
The text was updated successfully, but these errors were encountered: