Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: sep-raft-log: update replica snapshot creation #93246

Open
tbg opened this issue Dec 8, 2022 · 3 comments
Open

kvserver: sep-raft-log: update replica snapshot creation #93246

tbg opened this issue Dec 8, 2022 · 3 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication KV Replication Team

Comments

@tbg
Copy link
Member

tbg commented Dec 8, 2022 •
edited by cockroach-jira-scripts

Creation of a replica snapshot1 need not involve the log engine. Update the method so that it explicitly reads only from the state engine, once we have #93243.

Epic: CRDB-220

Jira issue: CRDB-22239

Footnotes

  1. https://github.com/cockroachdb/cockroach/blob/3d8819a85e9b1c668031e7ad294acae9944730bc/pkg/kv/kvserver/replica_raftstorage.go#L218-L288 ↩
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication KV Replication Team labels Dec 8, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 8, 2022

cc @cockroachdb/replication

@tbg
Copy link
Member Author

tbg commented Dec 19, 2022

This is mostly a no-op, sending a snapshot already only reads replicated state:

cockroach/pkg/kv/kvserver/store_snapshot.go

Line 571 in e532c65

err := rditer.IterateReplicaKeySpans(snap.State.Desc, snap.EngineSnap, true, /* replicatedOnly */

@tbg
Copy link
Member Author

tbg commented Mar 15, 2023

Unassigning as we pause work on separate raft log for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication KV Replication Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbg