Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make testrace PKG=./util/metrics #94

Closed
tbg opened this issue Sep 29, 2014 · 1 comment
Closed

make testrace PKG=./util/metrics #94

tbg opened this issue Sep 29, 2014 · 1 comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@tbg
Copy link
Member

tbg commented Sep 29, 2014

race testing may occasionally fail, probably due to channels filling up.

E0929 15:39:02.424096 08458 metrics.go:566] a raw subscriber has allowed their channel to fill up. dropping their metrics on the floor rather than blocking.

E0929 15:39:02.424554 08458 metrics.go:566] a raw subscriber has allowed their channel to fill up. dropping their metrics on the floor rather than blocking.

E0929 15:39:02.424627 08458 metrics.go:569] this raw subscriber has caused dropped metrics at least 3 times in a row. closing the channel.

--- FAIL: TestUpdateSubscribers (0.00 seconds)

metrics_test.go:256: received no raw metrics from the MetricSystem after 2 milliseconds.

metrics_test.go:264: received no processed metrics from the MetricSystem after 2 milliseconds.

FAIL

FAIL github.com/cockroachdb/cockroach/util/metrics 0.045s

make: *** [testrace] Error 1

The command "make testrace" exited with 2.

Done. Your build exited with 1.
@tbg tbg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 29, 2014
@tbg
Copy link
Member Author

tbg commented Sep 30, 2014

fixed by @spencerkimball in #95

@tbg tbg closed this as completed Sep 30, 2014
soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

1 participant