Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: write a mixed version restore test #96367

Closed
msbutler opened this issue Feb 1, 2023 · 3 comments · Fixed by #101730
Closed

backupccl: write a mixed version restore test #96367

msbutler opened this issue Feb 1, 2023 · 3 comments · Fixed by #101730
Assignees
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Feb 1, 2023

We currently allow for mixed version table and database restores but we don't test them. We should by using #92431

Jira issue: CRDB-24160

Epic CRDB-20915

@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels Feb 1, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 1, 2023

cc @cockroachdb/disaster-recovery

@blathers-crl
Copy link

blathers-crl bot commented Mar 10, 2023

Hi @msbutler, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@msbutler msbutler added the branch-release-23.1 Used to mark GA and release blockers and technical advisories for 23.1 label Mar 10, 2023
@rhu713 rhu713 assigned renatolabs and unassigned rhu713 Mar 14, 2023
renatolabs added a commit to renatolabs/cockroach that referenced this issue Apr 20, 2023
This commit updates the `backup/mixed-version` (now
`backup-restore/mixed-version`) to also perform mixed-version
restores. At a high level, it introduces a new function that runs in
mixed-version state that will randomly attempt to restore a subset of
the backups taken up to that point during the test.

The test will verify that we are able to restore, in mixed version,
backups taken in the previous version _and_ in mixed version.

Resolves: cockroachdb#96367.

Epic: CRDB-19321

Release note: None
@dt dt removed GA-blocker blocks-23.1.0-rc.1 branch-release-23.1 Used to mark GA and release blockers and technical advisories for 23.1 labels Apr 27, 2023
@dt
Copy link
Member

dt commented Apr 27, 2023

The test has been written; it hasn't merged yet but merging does not need to block 23.1.0

renatolabs added a commit to renatolabs/cockroach that referenced this issue Apr 28, 2023
This commit updates the `backup/mixed-version` (now
`backup-restore/mixed-version`) to also perform mixed-version
restores. At a high level, it introduces a new function that runs in
mixed-version state that will randomly attempt to restore a subset of
the backups taken up to that point during the test.

The test will verify that we are able to restore, in mixed version,
backups taken in the previous version _and_ in mixed version.

Resolves: cockroachdb#96367.

Epic: CRDB-19321

Release note: None
craig bot pushed a commit that referenced this issue May 10, 2023
101730: roachtest: add mixed-version restores to backup test r=smg260,herkolategan a=renatolabs

This commit updates the `backup/mixed-version` (now
`backup-restore/mixed-version`) to also perform mixed-version
restores. At a high level, it introduces a new function that runs in
mixed-version state that will randomly attempt to restore a subset of
the backups taken up to that point during the test.

The test will verify that we are able to restore, in mixed version,
backups taken in the previous version _and_ in mixed version.

Resolves: #96367.

Epic: [CRDB-19321](https://cockroachlabs.atlassian.net/browse/CRDB-19321)

Release note: None

Co-authored-by: Renato Costa <renato@cockroachlabs.com>
@craig craig bot closed this as completed in b5410ea May 10, 2023
Disaster Recovery Backlog automation moved this from Triage to Done May 10, 2023
renatolabs added a commit to renatolabs/cockroach that referenced this issue May 25, 2023
This commit updates the `backup/mixed-version` (now
`backup-restore/mixed-version`) to also perform mixed-version
restores. At a high level, it introduces a new function that runs in
mixed-version state that will randomly attempt to restore a subset of
the backups taken up to that point during the test.

The test will verify that we are able to restore, in mixed version,
backups taken in the previous version _and_ in mixed version.

Resolves: cockroachdb#96367.

Epic: CRDB-19321

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery
Development

Successfully merging a pull request may close this issue.

5 participants