Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc: login button fails to appear after successful configuration #97298

Closed
dhartunian opened this issue Feb 17, 2023 · 2 comments
Closed

oidc: login button fails to appear after successful configuration #97298

dhartunian opened this issue Feb 17, 2023 · 2 comments
Assignees
@dhartunian
Labels
A-observability-inf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@dhartunian
Copy link
Collaborator

dhartunian commented Feb 17, 2023 •
edited by cockroach-jira-scripts

After successful set up of OIDC in version 22.2.1 the login button fails to appear in DB Console.

The message initialized OIDC server appears in the logs and /oidc/v1/login endpoints works but the button does not appear.

Jira issue: CRDB-24621
@dhartunian dhartunian added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-observability-inf labels Feb 17, 2023
@dhartunian dhartunian self-assigned this Feb 17, 2023
@dhartunian dhartunian mentioned this issue Feb 17, 2023
Closed
@umi0410
Copy link

umi0410 commented Feb 17, 2023

I don't think server.oidc_authentication.autologin is working either.

  • server.oidc_authentication.autologin=true, but no redirect.
  • server.oidc_authentication.autologin=false, but no OIDC login button.

@dhartunian
Copy link
Collaborator Author

@umi0410 I was able to reproduce this on 22.2.1 this was fixed in 22.2.2 via #94067
Please upgrade to any version after 22.2.1.

@Shivs11 Shivs11 mentioned this issue Apr 20, 2023
Merged
Shivs11 added a commit to Shivs11/cockroach that referenced this issue Apr 21, 2023
@Shivs11
sql: adding version gates for changes related to JSON forward indexes
5e32b80 
Previously, cockroachdb#99275 and cockroachdb#97298 were responsible for laying the
foundations of a JSON lexicographical order as well as enabling JSON
forward indexes in CRDB. However, these commits did not account for
version gates. In a given cluster, all of its nodes are required to be
at a certain version number for creating JSON forward indexes as well as
for ordering JSON columns.  Thus, this PR aims to enable version gates
for ensuring all nodes in a given cluster meet this requirement.

Epic: CRDB-24501

Release note (sql change): This PR adds version gates which requires all
nodes in a given cluster to have a minimum binary version number which
in turn is required for creating forward indexes on JSON columns and for
ordering JSON columns.

Fixes: cockroachdb#35706
Shivs11 added a commit to Shivs11/cockroach that referenced this issue Apr 24, 2023
@Shivs11
sql: adding version gates for changes related to JSON forward indexes
e287ba9 
Previously, cockroachdb#99275 and cockroachdb#97298 were responsible for laying the
foundations of a JSON lexicographical order as well as enabling JSON
forward indexes in CRDB. However, these commits did not account for
version gates. In a given cluster, all of its nodes are required to be
at a certain version number for creating JSON forward indexes as well as
for ordering JSON columns.  Thus, this PR aims to enable version gates
for ensuring all nodes in a given cluster meet this requirement.

Epic: CRDB-24501

Release note (sql change): This PR adds version gates which requires all
nodes in a given cluster to have a minimum binary version number which
in turn is required for creating forward indexes on JSON columns and for
ordering JSON columns.

Fixes: cockroachdb#35706
Shivs11 added a commit to Shivs11/cockroach that referenced this issue Apr 26, 2023
@Shivs11
sql: adding version gates for changes related to JSON forward indexes
5ee49ff 
Previously, cockroachdb#99275 and cockroachdb#97298 were responsible for laying the
foundations of a JSON lexicographical order as well as enabling JSON
forward indexes in CRDB. However, these commits did not account for
version gates. In a given cluster, all of its nodes are required to be
at a certain version number for creating JSON forward indexes as well as
for ordering JSON columns.  Thus, this PR aims to enable version gates
for ensuring all nodes in a given cluster meet this requirement.

Epic: CRDB-24501

Release note (sql change): This PR adds version gates which requires all
nodes in a given cluster to have a minimum binary version number which
in turn is required for creating forward indexes on JSON columns and for
ordering JSON columns.

Fixes: cockroachdb#35706
Shivs11 added a commit to Shivs11/cockroach that referenced this issue Apr 26, 2023
@Shivs11
sql: adding version gates for changes related to JSON forward indexes
676c402 
Previously, cockroachdb#99275 and cockroachdb#97298 were responsible for laying the
foundations of a JSON lexicographical order as well as enabling JSON
forward indexes in CRDB. However, these commits did not account for
version gates. In a given cluster, all of its nodes are required to be
at a certain version number for creating JSON forward indexes as well as
for ordering JSON columns.  Thus, this PR aims to enable version gates
for ensuring all nodes in a given cluster meet this requirement.

Epic: CRDB-24501

Release note (sql change): This PR adds version gates which requires all
nodes in a given cluster to have a minimum binary version number which
in turn is required for creating forward indexes on JSON columns and for
ordering JSON columns.

Fixes: cockroachdb#35706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhartunian dhartunian

Labels
A-observability-inf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhartunian @umi0410