Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test: TestLogic_mixed_version_external_connections_owner_id failed #98594

Closed
cockroach-teamcity opened this issue Mar 14, 2023 · 2 comments
Closed

pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test: TestLogic_mixed_version_external_connections_owner_id failed #98594

cockroach-teamcity opened this issue Mar 14, 2023 · 2 comments
Assignees
@rafiss
Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 14, 2023 •
edited by cockroach-jira-scripts

pkg/sql/logictest/tests/cockroach-go-testserver-upgrade-to-master/cockroach-go-testserver-upgrade-to-master_test.TestLogic_mixed_version_external_connections_owner_id failed with artifacts on master @ 3b326c30b5b6571132d490655f8c55fc3b89fea5:

=== RUN   TestLogic_mixed_version_external_connections_owner_id
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/4b133010395be04e9844991469647fd3/logTestLogic_mixed_version_external_connections_owner_id2660561548
    test_log_scope.go:79: use -show-logs to present logs inline
panic: empty connection string

goroutine 126 [running]:
github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).pollListeningURLFile(0x40016004e0, 0x2)
	github.com/cockroachdb/cockroach-go/v2/testserver/external/com_github_cockroachdb_cockroach_go_v2/testserver/testserver.go:737 +0x674
github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).StartNode.func1()
	github.com/cockroachdb/cockroach-go/v2/testserver/external/com_github_cockroachdb_cockroach_go_v2/testserver/testservernode.go:109 +0x2c
created by github.com/cockroachdb/cockroach-go/v2/testserver.(*testServerImpl).StartNode
	github.com/cockroachdb/cockroach-go/v2/testserver/external/com_github_cockroachdb_cockroach_go_v2/testserver/testservernode.go:108 +0xa98
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-25349
@cockroach-teamcity cockroach-teamcity added branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 14, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 14, 2023
@cockroach-teamcity cockroach-teamcity added this to Triage in SQL Queries Mar 14, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 14, 2023
@mgartner
Copy link
Collaborator

@rafiss Was your recent fix meant to address this, or is it separate?

@rafiss
Copy link
Collaborator

rafiss commented Mar 14, 2023

This is a separate one, but requires more work. Some background: https://cockroachlabs.slack.com/archives/C016CAD2HQ8/p1678457050798969

For now, I'll skip

@rafiss rafiss self-assigned this Mar 14, 2023
@rafiss rafiss removed the T-sql-queries SQL Queries Team label Mar 14, 2023
@rafiss rafiss added this to Triage in SQL Sessions - Deprecated via automation Mar 14, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Mar 14, 2023
@rafiss rafiss mentioned this issue Mar 14, 2023
Merged
@rafiss rafiss mentioned this issue Mar 14, 2023
Closed
craig bot pushed a commit that referenced this issue Mar 15, 2023
@erikgrinaker @rafiss
Merge #98616 #98628
a2484ec 
98616: base: don't derive range lease duration from Raft election timeout r=erikgrinaker a=erikgrinaker

This patch makes `RangeLeaseDuration` a constant value, independent of the Raft election timeout, and adds an environment variable `COCKROACH_RANGE_LEASE_DURATION` to tune it. Even though there is a coupling between Raft elections and lease acquisitions, there is no strong reason why these values should directly depend on each other, and this makes it much safer and easier for advanced users to adjust the lease duration.

Touches #94704.

Epic: none
Release note (ops change): The range lease duration can now be adjusted via the environment variable `COCKROACH_RANGE_LEASE_DURATION`. Users are advised to exercise caution when adjusting this, and consider the relationship with e.g. Raft election timeouts and network timeouts.

98628: logictest: skip mixed version test r=rafiss a=rafiss

It's still flaky, so let's skip until we have another fix ready

informs #98594
informs #98612
informs #95247

Release note: None

Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
This was referenced Mar 15, 2023
Merged
Merged
@cucaroach cucaroach removed this from Triage in SQL Queries Mar 21, 2023
craig bot pushed a commit that referenced this issue Mar 22, 2023
@lyang24 @rafiss
Merge #98709 #98885 #99001
428d9f6 
98709: sql: Add optional From clause for update help msg r=chengxiong-ruan a=lyang24

Fixes: #98662


Testing: 
<img width="397" alt="Screen Shot 2023-03-15 at 1 05 17 PM" src="https://user-images.githubusercontent.com/20375035/225430872-4e5f50f3-8af1-4fd8-8c76-073c2efe12b0.png">
tested on the demo sql shell, please let me know the places i can add additional tests.

Release note (sql change): fix helper message on update sql to include optional from cause.

98885: sql: add system.statement_activity and system.transaction_activity r=j82w a=j82w

The system.statement_activity and system.transaction_activity tables 
are being added to allow the ui to get fast and reliable results of the
most important statements and transactions.

A separate PR will add a new crdb_internal view to allow non-admins
to access the data, and another PR to add a job that will run once every 
hour to add the new data and cleanup old data.

Epic: none
Part of: #98882

Release note (sql): Add system.statement_activity
and system.transaction_activity. These tables will be used to populate 
the SQL Activity pages, and will contain the top N stmts/txns based on 
different key columns.

99001: logictest: don't use hardcoded ports for mixed version test r=rafiss a=rafiss

This should resolve flakes we've seen where the server attempts to bind a port that is already in use.

informs #95247
informs #98549
informs #98612
informs #98594

We won't know if it fixes them until after CI runs for a few days.

Release note: None

Co-authored-by: Eric.Yang <eyang@roblox.com>
Co-authored-by: j82w <jwilley@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@blathers-crl blathers-crl bot mentioned this issue Mar 22, 2023
Merged
@rafiss rafiss closed this as completed Mar 23, 2023
SQL Sessions - Deprecated automation moved this from Triage to Done Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
branch-master Failures on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. skipped-test T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Done
Milestone
23.1
Development

No branches or pull requests
3 participants
@mgartner @rafiss @cockroach-teamcity