userfile: IMPORT doesn't correctly build a default 'host' for users with special characters in the username

[smcvey]

Describe the problem

Create a user with a . in the username (or any other special character).

CREATE USER "my.user" WITH PASSWORD 'p';

Use this user to upload a small csv file for future import:

cockroach userfile upload data.csv data.csv -u my.user

Note that this creates the userfiles table with names in a hex format (encode('my.user', 'hex')):

  public      | userfilesx_6d792e75736572_upload_files   | table | my.user     |                   0 | NULL
  public      | userfilesx_6d792e75736572_upload_payload | table | my.user     |                   0 | NULL

Now create a table and try to import that file:

my.user@localhost:26257/defaultdb> create table t(id uuid primary key);
CREATE TABLE

Time: 17ms total (execution 17ms / network 0ms)

my.user@localhost:26257/defaultdb> import into t (id) csv data ('userfile:///data.csv');
ERROR: failed to create file table to store uploaded file names: create-file-table: at or near "_upload_files": syntax error
SQLSTATE: 42601
DETAIL: source SQL:
CREATE TABLE defaultdb.public."userfiles_my.user"_upload_files (filename STRING PRIMARY KEY,
                                                 ^
HINT: try \h CREATE TABLE

It looks like it's attempting to deal with a table called "userfiles_my.user"_upload_files instead of the hex-encoded version.

Running this as a user without a special character in the name works fine.

Jira issue: CRDB-26160

[blathers-crl]

cc @cockroachdb/disaster-recovery

[chengxiong-ruan]

We need to handle the table name construction better here. We made composedTableName by adding the userfiles_ prefix to the username, then composedTableName.SQLIdentifier() returns a double quoted version of the string because there is a dot. We may do something similar to this function where the user name is hexed if it contains fun characters.