bazel: nogo crash/segfault #99988
Comments
knz
added
C-bug
|
@knz Can you push this commit |
|
It's embededded in the crdb |
|
@stevendanna shall i assign this to you? I know you were toying with this. |
|
😭 I was actually chasing a different panic. In my case, I wasn't able to get a good reproduction easily. I wonder if bumping |
|
just hit another buildssa nogo crash |
|
@rickystewart currently master uses version v0.6.0 of |
|
@msbutler I don't know of anything blocking, but it's not up to me --this is one of the "core dependencies" to the database so we need a wider audience for a review. @knz Are you aware of any specific problems w upgrading |
|
latest x/tools seems reasonable but let's also see how many other things that pulls in :) |
|
ok lemme see what happens. |
|
@knz wdyt? diff on master after running |
|
Sgtm! |
|
@rickystewart when I attempt to run I have seen an internal thread which indicates that a bump of |
|
We would probably have to upgrade |
|
well, it looks like updating |
|
@msbutler Try the following patch. Michael, instead of upgrading |
|
yup, i'll open a PR for a bump to |
The patch updates golang.org/x/term from v0.6.0 to v0.7.0. The update is in part motivated by spurious nogo compilation errors tracked in cockroachdb#99988. Informs cockroachdb#99988 Release note: None
105351: builtins: create function to aggregate aggregated stmt metadata r=xinhaoz a=xinhaoz ## server: prefer string concat over str format where possible A number of places in the combined stats api were using string format where a string concatenation would have worked. Release note: None Epic: none ## server: format sql activity queries Reformat queries for consistency and readability. Epic: none Release note: None ## builtins: create function to aggregate aggregated stmt metadata The statement activity table used to cache aggregated stmt stats for the sql activity page stores aggregated metadata. Previously we used the same query as the one used for system.statement_statistics, which stores unaggregated metadata, on the activity table. Using the aggregate function for unaggregated metadata on aggregated metadata was nto valid, leading to incorrect JSON fields being produced. This commit introduces the builtin `crdb_internal.combine_aggregated_stmt_metadata` which can be used to correctly aggregate the metadata column on the stmt activity table. Fixes: #103895 Release note (bug fix): On the UI, selecting a database filter from the filters menu in the sql activity page should function as expected. This fixes a preivous bug where the filter would break and not show any results when the results were retrieved from the stmt activity table instead of the persisted table. 106256: deps: update golang.org/x/tools r=rickystewart a=msbutler The patch updates golang.org/x/term from v0.6.0 to v0.7.0. The update is in part motivated by spurious nogo compilation errors tracked in #99988. Informs: #99988 Release note: None Epic: none Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com> Co-authored-by: Michael Butler <butler@cockroachlabs.com>
|
Looks like the dep is good now. |
The patch updates golang.org/x/term from v0.6.0 to v0.7.0. The update is in part motivated by spurious nogo compilation errors tracked in cockroachdb#99988. Informs cockroachdb#99988 Release note: None
Found here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/9325532?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true
cc @rickystewart for triage
Jira issue: CRDB-26167
Epic CRDB-36213
The text was updated successfully, but these errors were encountered: