sql: Fix bug preventing renaming of primary key columns #10018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Closing and reopening to try to un-wedge teamcity |
|
here you are, good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this has been broken since RENAME COLUMN was first introduced back in #2158.
It's possible that this should just be replaced by desc.AllNonDropIndexes(), but I'm not confident whether the behavior difference in the handling of Mutations between that and the current code is significant. Thoughts?
Fixes #9987
@paperstreet because he was unfortunate enough to be the last person to move this code around
This change is