New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: ui: fix Node Map view loading for insecure clusters #100214
Conversation
Node Map view on Cluster Overview page relies on `cluster` data that was fetched only from `Alerts` components when Db Console is loaded and Node Map view reused this data. But recently, the logic of requesting `cluster` data for alerts has been changed (and this is ok) and in turn it affected Node Map view as far as it cannot get required data to render. This change extends `ClusterVisualization` component (that renders Node Map view) to request `cluster` data when component is loaded or updated to ensure it doesn't rely on any component and self-contained. Release note (ui change): fix issue to properly render placeholder on Node Map view for insecure clusters.
cff2a3c
to
a2e870e
Compare
9c0b17e
to
02ac94d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @koorosh)
Backport 1/1 commits from #99781 on behalf of @koorosh.
/cc @cockroachdb/release
Node Map view on Cluster Overview page relies on
cluster
data that was fetched only fromAlerts
components when Db Console is loaded and Node Map view reused this data.But recently, the logic of requesting
cluster
data for alerts has been changed (and this is ok) and in turn it affected Node Map view as far as it cannot get required data to render.This change extends
ClusterVisualization
component (that renders Node Map view) to requestcluster
data when component is loaded or updated to ensure it doesn't rely on any component and self-contained.Release note (ui change): fix issue to properly render placeholder on Node Map view for insecure clusters.
Resolves: #99714
Affected by change: 2f96eeb#diff-df26ebfacd94f33f708d63db924dcf48fda69eb9a737159ee3aa739f27403c28L623-L625
Release justification: fixes for high-priority or high-severity bugs in existing functionality