Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: fix Node Map view loading for insecure clusters #100214

Merged
merged 1 commit into from Apr 3, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023

Backport 1/1 commits from #99781 on behalf of @koorosh.

/cc @cockroachdb/release


Node Map view on Cluster Overview page relies on cluster data that was fetched only from Alerts components when Db Console is loaded and Node Map view reused this data.
But recently, the logic of requesting cluster data for alerts has been changed (and this is ok) and in turn it affected Node Map view as far as it cannot get required data to render.

This change extends ClusterVisualization component (that renders Node Map view) to request cluster data when component is loaded or updated to ensure it doesn't rely on any component and self-contained.

Release note (ui change): fix issue to properly render placeholder on Node Map view for insecure clusters.

Resolves: #99714

Affected by change: 2f96eeb#diff-df26ebfacd94f33f708d63db924dcf48fda69eb9a737159ee3aa739f27403c28L623-L625


Release justification: fixes for high-priority or high-severity bugs in existing functionality

Node Map view on Cluster Overview page relies on `cluster` data
that was fetched only from `Alerts` components when Db Console
is loaded and Node Map view reused this data.
But recently, the logic of requesting `cluster` data for
alerts has been changed (and this is ok) and in turn it
affected Node Map view as far as it cannot get required data
to render.

This change extends `ClusterVisualization` component (that
renders Node Map view) to request `cluster` data when
component is loaded or updated to ensure it doesn't rely
on any component and self-contained.

Release note (ui change): fix issue to properly render placeholder
on Node Map view for insecure clusters.
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 30, 2023 21:08
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99781 branch from cff2a3c to a2e870e Compare March 30, 2023 21:08
@blathers-crl blathers-crl bot requested a review from kvoli March 30, 2023 21:08
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99781 branch from 9c0b17e to 02ac94d Compare March 30, 2023 21:08
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli requested a review from koorosh April 3, 2023 13:37
Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @koorosh)

@koorosh koorosh merged commit 66e8212 into release-23.1 Apr 3, 2023
6 checks passed
@koorosh koorosh deleted the blathers/backport-release-23.1-99781 branch April 3, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants