Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: kvserver: Add a metric for in-progress snapshots #100421

Merged
merged 1 commit into from
Apr 4, 2023
Merged

release-23.1: kvserver: Add a metric for in-progress snapshots #100421

merged 1 commit into from
Apr 4, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 2, 2023 •
edited by andrewbaptist
Loading

Backport 1/1 commits from #99843 on behalf of @andrewbaptist.

/cc @cockroachdb/release

Fixes: #98242

Knowing how many delegate snapshot requests are currently in-progress will be useful for detecting problems. This change adds a metric for this. It also updates the names of the previous stats to have the prefix range.snapshots vs range.snapshot to be consistent with other stats.

Epic: none

Release note: None

Release justification: This was identified as a useful stat during the KV premortem

@andrewbaptist
kvserver: Add a metric for in-progress snapshots
fff395f 
Fixes: #98242

Knowing how many delegate snapshot requests are currently in-progress
will be useful for detecting problems. This change adds a metric for
this. It also updates the names of the previous stats to have the prefix
`range.snapshots` vs `range.snapshot` to be consistent with other stats.

Epic: none

Release note (ops change): Adds a new stat
range.snapshots.delegate.in-progress and renames two existing stats.
They were never part of a release, so better to rename them before
23.1.0 is cut.
range.snapshot.delegate.successes -> range.snapshots.delegate.successes
range.snapshot.delegate.failures -> range.snapshots.delegate.failures
@blathers-crl blathers-crl bot requested a review from a team April 2, 2023 11:51
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 2, 2023 11:51
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 2, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 2, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 2, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99843 branch 2 times, most recently from d8e415f to fff395f Compare April 2, 2023 11:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

kvoli
kvoli approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist)

@andrewbaptist andrewbaptist merged commit f039a1a into release-23.1 Apr 4, 2023
@andrewbaptist andrewbaptist deleted the blathers/backport-release-23.1-99843 branch April 4, 2023 17:31
@cockroach-teamcity cockroach-teamcity mentioned this pull request Apr 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvoli kvoli kvoli approved these changes

@andrewbaptist andrewbaptist Awaiting requested review from andrewbaptist

Assignees

@andrewbaptist andrewbaptist

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @kvoli @andrewbaptist