-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: storage: encode ApproximateDiskBytes keys #100937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f40e293
to
d3d3874
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
1c03925
to
942cb50
Compare
nicktrav
approved these changes
Apr 7, 2023
Previously Engine.ApproximateDiskBytes accepted two roachpb.Keys for bounds which were passed directly to Pebble without additional encoding. When used with EngineCompare, Cockroach would incorrectly try to interpret the final byte as a version length. This could result in incorrect size calculations or ApproximateDiskBytes erroring on out-of-order span bounds. Epic: None Release note (bug fix): Fix a bug whereby some tables' physical disk space could not be calculated.
942cb50
to
aa323c8
Compare
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #100870 on behalf of @jbowens.
/cc @cockroachdb/release
Previously Engine.ApproximateDiskBytes accepted two roachpb.Keys for bounds which were passed directly to Pebble without additional encoding. When used with EngineCompare, Cockroach would incorrectly try to interpret the final byte as a version length. This could result in incorrect size calculations or ApproximateDiskBytes erroring on out-of-order span bounds.
Kudos to @THardy98 for uncovering this one.
Epic: None
Release note (bug fix): Fix a bug whereby some tables' physical disk space could not be calculated.
Release justification: Low-risk bug fix.