kvserver: fix rebalancing.(write|read)bytes desc #101499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kvoli
added
backport-23.1.x
The `rebalancing.readbytespersecond` and `rebalancing.writebytespersecond` metrics had incorrect descriptions which stated "written" for reads and "read" for writes. This commit updates the metric descriptions to be correct. Epic: none Release note (bug fix): Fix the metric description of `rebalancing.readbytespersecond`, `rebalancing.writebytespersecond` to correctly reference bytes read and bytes written respectively.
kvoli
force-pushed
the
230413.fix-rebalancing-metric-desc
branch
from
63a2655
to
2b42d80
Compare
tbg
approved these changes
Apr 14, 2023
|
bors r=tbg |
|
Build succeeded: |
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rebalancing.readbytespersecondandrebalancing.writebytespersecondmetrics had incorrect descriptions which stated "written" for reads and "read" for writes.This commit updates the metric descriptions to be correct.
Epic: none
Release note (bug fix): Fix the metric description of
rebalancing.readbytespersecond,rebalancing.writebytespersecondto correctly reference bytes read and bytes written respectively.