Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: restore: skip_localities_check no longer works #101893

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Apr 20, 2023

Backport 1/1 commits from #101682.

/cc @cockroachdb/release


Previously, there was no additional validation for generating zone configurations so if regions were
missing during the process no errors would be generated. Later on the generation process had validation added to validate that all regions reference existed within the zone configuration. To address this, this patch adds an option to skip validation of regions when
generating zone configurations.

Fixes: #100913
Release note (bug fix): Previously, RESTORE with skip_localities_check would still fail with errors if regions were missing on a cluster.
Release justification: low risk and fixes a regression

@blathers-crl
Copy link

blathers-crl bot commented Apr 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, there was no additional validation for
generating zone configurations during restore, so nothing
bad would happen if regions were missing during restore.
Later on, the zone config generation process had validation
to ensure all regions existed. This was problematic for
restores with skip_localities_check since we would still
incorrectly check localities.
To address this, this patch adds an option to skip validation
of regions when generating zone configurations.

Fixes: cockroachdb#100913

Release note (bug fix): Previously, RESTORE with skip_localities_check
would still fail with errors if regions were missing on a cluster.
@fqazi fqazi marked this pull request as ready for review April 20, 2023 13:45
@fqazi fqazi requested review from a team as code owners April 20, 2023 13:45
@fqazi fqazi requested review from a team and rhu713 and removed request for a team April 20, 2023 13:45
@fqazi fqazi merged commit fce5302 into cockroachdb:release-22.2 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants