status: avoid holding mutex over network i/o #10228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step in addressing a bad critical section in `(*MetricsRecorder).PrintAsText` which holds a mutex over the (possibly blocking, because network i/o) call to `(*PrometheusExporter).Export`.
Clarify that prometheus scrapes metrics, not holding on to any of their underlying state. Verified that all implementors of `PrometheusExportable` adhere to the expected semantics.
The writer passed to `(*MetricsRecorder).PrintAsText` may not consume quickly (after all, it is usually a TCP/IP connection) and when it doesn't, the resulting deadlock brought the server to its knees.
tbg
force-pushed
the
prometheus-critical-section
branch
from
6e22fd3
to
d6509d9
Compare
|
LGTM |
petermattis
approved these changes
Oct 26, 2016
|
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 1 of 1 files at r3. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
bdarnell
approved these changes
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The writer passed to
(*MetricsRecorder).PrintAsTextmay not consumequickly
(after all, it is usually a TCP/IP connection) and when it doesn't, the
resulting deadlock brought the server to its knees.
This change is